refactor(biometric): improve biometric request flow - #98
Merged
Merged
Conversation
Every Android library module gets consumerProguardFiles("consumer-rules.pro")
from AndroidLibraryConventionPlugin, but the new :core:biometrics module never
shipped the file. Gradle's mergeConsumerProguardFiles failed on it, taking down
android-test and the CodeQL java-kotlin autobuild in CI.
Also:
- scripts/new-module.sh now touches consumer-rules.pro for Android modules so
this can't recur for future scaffolded modules; test-new-module.py covers it.
- :core:biometrics and :core:identity have no Compose usage, so switch them
from keygo.android.compose to keygo.android.library and drop the
testFixtures Compose-runtime workaround that only exists to support the
Compose plugin's testFixtures interaction.
- drop core:security's now-dead androidx.biometric dependency now that
biometric prompt handling lives in :core:biometrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.