Skip to content

Remove the Feedback component #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
enf0rc3 wants to merge 1 commit into from
+2 −34
Closed

Remove the Feedback component #3323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions src/components/Feedback.astro
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions src/layouts/Default.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import ArticleNav from '../components/ArticleNav.astro';
import Header from '../components/Header.astro';
import Related from '../components/Related.astro';
import ArticleJourney from '../components/ArticleJourney.astro';
import Feedback from '../components/Feedback.astro';
import EditOnGithub from '../components/EditOnGithub.astro';
import LastUpdated from '../components/LastUpdated.astro';
import CopyMarkdown from '../components/CopyMarkdown.astro';
Expand Down Expand Up @@ -90,11 +89,6 @@ const showSearch = !isSearchPage;
</div>
<div class="page-content anim-show-parent" itemprop="articleBody">
<slot />
<Feedback
frontmatter={frontmatter}
headings={headings}
lang={lang}
/>
<Authors frontmatter={frontmatter} lang={lang} />
<Taxonomy frontmatter={frontmatter} lang={lang} />
<LastUpdated
Expand Down
4 changes: 2 additions & 2 deletions src/scripts/modules/headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ let status = null;
const timers = new WeakMap();

/**
* Scoped to .page-content headings with an id: the feedback prompt and the
* navigation render their own headings, and those have nothing to link to.
* Scoped to .page-content headings with an id: the navigation renders its own
* headings, and those have nothing to link to.
*
* Each heading is given an aria-label of its own text. A heading is named from
* its contents, and those contents include a nested control's name, so without
Expand Down