Repository navigation
v.out.ogr: Fix OGR_L_GetLayerDefn() result - #8071
Merged
Merged
Conversation
github-actions
Bot
added
vector
Contributor
Author
|
I found this issue while working on the vcpkg port of grass. See: microsoft/vcpkg#54374 |
Member
|
This will need a bit of rework to not fail existing workflows |
nilason
reviewed
Oct 15, 2026
nilason
left a comment
nilason
left a comment
Contributor
There was a problem hiding this comment.
Just after quick read, the following changes are probably needed.
ptitjano
force-pushed
the
v-out-ogr-feature-defn
branch
3 times, most recently
from
October 15, 2026 07:59
dd84be6 to
0e48193
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
`OGR_L_GetLayerDefn()` returns an `OGRFeatureDefnH`, but the result was stored in an `OGRFieldDefnH`. This error only occurs when GDAL is built with GDAL_DEBUG.
ptitjano
force-pushed
the
v-out-ogr-feature-defn
branch
from
October 15, 2026 08:04
0e48193 to
7612b72
Compare
Contributor
Author
Indeed. This should be fixed now. Thanks. |
echoix
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OGR_L_GetLayerDefn()returns anOGRFeatureDefnH, but the result was stored in anOGRFieldDefnH.This error only occurs when GDAL is built with GDAL_DEBUG.