Repository navigation
Conversation
SirPyTech
commented
Oct 14, 2026
Comment on lines
-387
to
+388
| for category in self: | ||
| if category.parent_id: | ||
| category.complete_name = ( | ||
| f"{category.parent_id.complete_name} / {category.name}" | ||
| for directory in self: |
Author
There was a problem hiding this comment.
Here I also renamed from category to directory because we are in the Directory model, category was probably coming from a copy/paste
| name="name" | ||
| filter_domain="['|', ('name', 'ilike', self), ('parent_id', 'child_of', raw_value)]" | ||
| /> | ||
| <field name="complete_name" /> |
Author
There was a problem hiding this comment.
If I understand the old filter correctly, complete_name does the same thing and is more aligned with directories' search
Comment on lines
+430
to
+433
| <label for="code" class="oe_edit_only" /> | ||
| <h3> | ||
| <field name="code" /> | ||
| </h3> |
Author
There was a problem hiding this comment.
This is how it shows: 
I'm not sure oe_edit_only does anything, but I added it because it's there for name too.
Comment on lines
+55
to
+58
| <label for="code" class="oe_edit_only" /> | ||
| <h3> | ||
| <field name="code" /> | ||
| </h3> |
Author
There was a problem hiding this comment.
This is how it shows: 
I'm not sure oe_edit_only does anything, but I added it because it's there for name too.
SirPyTech
marked this pull request as ready for review
October 14, 2026 08:38
SirPyTech
force-pushed
the
18.0-imp-dms-add_code_complete_name
branch
from
October 14, 2026 13:19
a2c04ca to
5dc05fc
Compare
HekkiMelody
approved these changes
Oct 15, 2026
HekkiMelody
left a comment
HekkiMelody
left a comment
Contributor
There was a problem hiding this comment.
Code and functional review, LGTM
HekkiMelody
reviewed
Oct 15, 2026
SirPyTech
force-pushed
the
18.0-imp-dms-add_code_complete_name
branch
from
October 15, 2026 13:52
5dc05fc to
10e777f
Compare
HekkiMelody
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a "Code" field to categories and directories, that is used to compute their complete name as
[code] name.If the new
codefield is left empty, the behavior remains as it was before this PR.