Skip to content

feat: add keyboard shortcuts for comparison form and table search - #246

Merged
O2sa merged 1 commit into
O2sa:mainfrom
SamuelMackovych:feat/search-hotkeys
Oct 15, 2026
Merged

O2sa merged 1 commit into
O2sa:mainfrom
SamuelMackovych:feat/search-hotkeys

Conversation

@SamuelMackovych

Copy link
Copy Markdown
Contributor

Closes #222

Summary

  • Added keyboard shortcuts to the comparison form and the leaderboard search fields
  • / focuses the first empty username field on the comparison form (or the first field if both are filled), and the search field on leaderboard pages
  • Ctrl+Enter / ⌘+Enter submits the comparison form from anywhere in the form
  • Escape clears a filled field, and a second press leaves it
  • Shortcuts don't fire while typing in other inputs, inside dialogs, during IME composition, or with browser modifier combos
  • Show shortcut hints with a new Kbd UI component and expose them with aria-keyshortcuts
  • Extract a shared SearchField component for the leaderboard table and country grid, and switch the icon padding to logical properties (start/ps) so it displays correctly in Arabic UI
  • Add English and Arabic shortcut labels

Testing

  • New unit tests for useHotkeys helpers, compare form shortcuts, and leaderboard search
  • All unit tests passed
  • Manually tested /, Ctrl/⌘+Enter and Escape in the browser
  • Manually verified English and Arabic UI

@vercel

vercel Bot commented Oct 15, 2026

Copy link
Copy Markdown

@SamuelMackovych is attempting to deploy a commit to the osama's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! ✅

A maintainer will review this soon. Please be patient while we take a look. 🙌

@vercel

vercel Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dev-impact Ready Ready Preview Oct 15, 2026 7:11pm UTC

@O2sa
O2sa merged commit 3becd1c into O2sa:main Oct 15, 2026
4 checks passed
@O2sa

O2sa commented Oct 15, 2026

Copy link
Copy Markdown
Owner

🎊 Welcome, @SamuelMackovych! Your first contribution has been merged! 🚀

Thank you for helping improve the project! If you find this tool useful, please consider giving us a ⭐ star on GitHub—it helps more developers find our work and motivates us to keep improving!

This branch was successfully deployed

1 active deployment
Preview — 41fc7636 Deployed Oct 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Add keyboard shortcuts for comparison form and table search

2 participants