Skip to content

fix(comparison): label icon-only form buttons - #244

Merged
O2sa merged 1 commit into
O2sa:mainfrom
CreedTech:fix/compare-form-labels-243
Oct 13, 2026
Merged

O2sa merged 1 commit into
O2sa:mainfrom
CreedTech:fix/compare-form-labels-243

Conversation

@CreedTech

Copy link
Copy Markdown
Contributor

Fixes #243

The swap and reset buttons now have accessible names from their existing translations. Their tooltips and behavior remain the same.

Checks: pnpm test --run (203 passed), pnpm lint, pnpm exec tsc --noEmit, pnpm validate-locales, and Prettier on the changed file.

Additionally, at the time of submission of this PR:

  • The referred issue is not blocked currently
  • All unit tests passed after changes were made

@vercel

vercel Bot commented Oct 13, 2026

Copy link
Copy Markdown

@CreedTech is attempting to deploy a commit to the osama's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! ✅

A maintainer will review this soon. Please be patient while we take a look. 🙌

@O2sa
O2sa merged commit 6ceee81 into O2sa:main Oct 13, 2026
1 of 2 checks passed
@O2sa

O2sa commented Oct 13, 2026

Copy link
Copy Markdown
Owner

🎊 Welcome, @CreedTech! Your first contribution has been merged! 🚀

Thank you for helping improve the project! If you find this tool useful, please consider giving us a ⭐ star on GitHub—it helps more developers find our work and motivates us to keep improving!

@CreedTech

Copy link
Copy Markdown
Contributor Author

🎊 Welcome, @CreedTech! Your first contribution has been merged! 🚀

Thank you for helping improve the project! If you find this tool useful, please consider giving us a ⭐ star on GitHub—it helps more developers find our work and motivates us to keep improving!

Thank you, @O2sa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Add missing aria-labels to icon-only buttons in CompareForm

2 participants