feat(recipes): dependency ordering, dry-run, and cloudinit post-boot apply

[NovusEdge]

Implements docs/specs/2026-08-10-recipe-system-fixes-design.md.

• Delete v1 metadata parser + wire cloudinit to v2. MatchesVM (via new MatchReason) is the sole capability checker. cloudinit.Prepare and clone.go build seeds through ManifestFor+ScriptContent+WrapScripts. sweepV1 warns when it moves a recipe it does not recognise as stoat's own.
• Dependency ordering. New depends manifest field, recipes.TopoSort with cycle detection, apply-time satisfaction checks, create/CLI validation (CheckDependencies), and TUI auto-add (ResolveDependencies, "Added docker (required by devtools)").
• Cloudinit post-boot apply. Drop ErrAppliedAtBoot; each recipe's runcmd writes a marker; discoverCloudInitApplied reads them over ssh to rebuild v.Applied.
• Dry-run. stoat apply --dry-run [--json] via PlanApply, computed host-side (works on stopped VMs).
• Docs. ## Reboot Behavior section in docs/recipe-spec-v2.md.
• Stage validation. Reject stage = "install" at add time until BYO ISO lands.

Excludes an unrelated concurrent apkovl.go banner change in the working tree.

Summary by CodeRabbit

• New Features
  • Added apply --dry-run to preview planned recipe actions in human-readable or JSON format.
  • Recipes now support dependencies, including automatic dependency selection, ordering, and clear validation errors.
  • Cloud-init VMs can apply recipes after boot and recover previously completed recipes.
  • Added one-time reboot support for disk-mode VMs after applying recipes.
• Bug Fixes
  • Improved compatibility and capability error messages.
  • Prevented unsupported install-stage recipes from being selected.
• Documentation
  • Updated recipe v2 behavior, migration guidance, and reboot rules.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: adad47d3-fd86-4ad3-b6d0-384508bb47eb

📥 Commits

Reviewing files that changed from the base of the PR and between af6c143 and bed3922.

📒 Files selected for processing (34)

• docs/recipe-spec-v2.md
• docs/specs/2026-08-10-recipe-system-fixes-design.md
• internal/backend/cloudinit.go
• internal/cli/cli.go
• internal/cli/grammar.go
• internal/cli/run_apply.go
• internal/cli/subcommands_test.go
• internal/cli/wire/errors.go
• internal/cli/wire/errors_test.go
• internal/cloudinit/scripts.go
• internal/cloudinit/scripts_test.go
• internal/core/apply.go
• internal/core/apply_test.go
• internal/core/clone.go
• internal/core/core.go
• internal/core/deps.go
• internal/core/deps_test.go
• internal/recipes/deps.go
• internal/recipes/deps_test.go
• internal/recipes/manifest.go
• internal/recipes/manifest_test.go
• internal/recipes/metadata.go
• internal/recipes/metadata_test.go
• internal/recipes/recipes.go
• internal/recipes/recipes_test.go
• internal/sshx/sshx_test.go
• internal/tui/autoprov_test.go
• internal/tui/deps.go
• internal/tui/edit.go
• internal/tui/edit_test.go
• internal/tui/form.go
• internal/tui/labels.go
• internal/tui/provision.go
• internal/tui/provision_test.go

---

Walkthrough

The change moves recipe execution to v2 manifests, adds dependency validation and ordering, supports cloud-init post-boot state recovery, introduces host-side apply planning with CLI dry-run output, and documents disk-mode reboot behavior.

Changes

Recipe Apply System

Layer / File(s)	Summary
Manifest migration and script provisioning docs/specs/..., internal/backend/cloudinit.go, internal/core/clone.go, internal/core/core.go, internal/recipes/*, internal/sshx/sshx_test.go, internal/tui/*_test.go	Recipe resolution now requires v2 manifests. Applicability uses manifest metadata. Cloud-init and clone provisioning load OS-specific script content. Legacy files use checksum-based sweep handling.
Dependency contracts and ordering internal/recipes/deps.go, internal/core/deps.go, internal/core/apply.go, internal/tui/deps.go, internal/tui/edit.go, internal/tui/form.go, internal/tui/*_test.go	Manifests declare dependencies. Core resolution validates missing, incompatible, and cyclic dependencies. Apply uses topological ordering. TUI selection adds required recipes and reports additions.
Cloud-init marker recovery internal/cloudinit/scripts.go, internal/core/apply.go, internal/cli/wire/errors.go, internal/tui/provision.go, internal/*_test.go	Successful cloud-init scripts write per-recipe markers. Apply discovers markers over SSH and reconstructs v.Applied. The obsolete applied-at-boot refusal path was removed.
Host-side apply planning internal/core/apply.go, internal/cli/cli.go, internal/cli/grammar.go, internal/cli/run_apply.go, internal/core/apply_test.go	ApplyPlan and PlanApply calculate run and skip actions. apply --dry-run prints the plan as text or JSON without executing recipes.
Reboot and implementation specification docs/recipe-spec-v2.md, docs/specs/2026-08-10-recipe-system-fixes-design.md, internal/core/apply_test.go	Documentation defines disk-mode-only reboot aggregation, live-mode restart handling, install-stage rejection, migration behavior, and expanded validation coverage.

Estimated code review effort: 4 (Complex) | ~60 minutes

Possibly related PRs

• NovusEdge/stoat#22: Replaces v1 recipe script fallback flow with manifest-based resolution.
• NovusEdge/stoat#12: Earlier changes to core apply, clone, cloud-init, and manifest behavior.
• NovusEdge/stoat#16: Related install-stage recipe handling.

Poem

A rabbit checks the manifest bright,
Orders each recipe left to right.
Cloud-init marks the work it grew,
Dry-run plans what Stoat will do.
Reboot waits till runs are through.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch recipe-system-fixes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}