Repository navigation
docs: don't recommend a webhook timestamp tolerance by default - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webhook examples passed a 300-second timestamp tolerance, and the README called 300 a reasonable value. Nomba does not document whether automatic retries get a fresh
nomba-timestamp. If they keep the original, a short tolerance would reject legitimate retries after an outage, and paid orders would never be confirmed.requestIdis the main defence; the tolerance stays off by default, and should only be enabled (generously) after confirming redeliveries carry a new timestamp.orderReference,merchantTxRefandtokenKeyare not signed, so money decisions should be confirmed withtransactions.get.Docs only: no SDK code or defaults change (the tolerance was already off by default).
After this is merged and released, run
node scripts/sync-sdk-references.mjsin the skills repo to refresh the nomba-webhooks skill references.