feat: Emit format-based validation attributes for email and phone - #151
Open
nikcio wants to merge 1 commit into
Open
feat: Emit format-based validation attributes for email and phone#151nikcio wants to merge 1 commit into
nikcio wants to merge 1 commit into
Conversation
Emit [EmailAddress] for format: email and [Phone] for format: phone when EmitValidationAttributes is enabled. These are standard System.ComponentModel.DataAnnotations attributes used by ASP.NET Core model validation. - Add GetFormatValidationAttribute helper to map formats to attributes - Update HasValidationConstraints to detect format-based attributes - Suppress with --no-validation-attributes flag (existing option) - Add 5 tests: email, phone, opt-out, unknown format, compilation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Emit for and for when is enabled. These are standard attributes used by ASP.NET Core model validation.
Example
Implementation
Testing
All 276 tests pass (266 existing + 5 new). New tests include compilation with .