fix: Flatten properties from additional allOf refs - #147
Draft
nikcio wants to merge 1 commit into
Draft
Conversation
When a schema uses allOf with multiple $ref$ members, only the first $ref$ becomes the C# base type. Previously, additional $ref$ members were silently dropped, losing their properties. Now, properties from additional $ref$ members are resolved and flattened into the derived record (since C# doesn't support multiple inheritance). - CollectProperties now accepts the base ref schema and resolves additional $ref$ members' properties instead of skipping them - CollectRequired similarly collects required fields from additional refs - Add tests for multi-ref flattening, required field collection, and compilation with TreatWarningsAsErrors
nikcio
marked this pull request as draft
August 26, 2026 22:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When a schema uses allOf with multiple ref members, only the first ref becomes the C# base type. Previously, additional ref members were silently dropped, losing their properties.
Now, properties from additional ref members are resolved and flattened into the derived record (since C# doesn't support multiple inheritance).
Example
Derived:
allOf:
- ref: Base -> base type (inheritance)
- ref: Mixin -> properties flattened into Derived
- type: object -> properties included directly
Changes
Testing
All 244 tests pass (241 existing + 3 new).