Repository navigation
security: rotate registry publisher key to production (R1) - #3
Merged
Merged
Conversation
- REGISTRY_TRUSTED_PUBLIC_KEYS 轮换为 ccb-publisher-2026-09(rehearsal key 移除),registry 与云模板通道共用 - 远程 registry 1.2.1 与 templates v1.0.0 已用 production key 重签并通过 verify 完整链 + 20/20 对抗自检(web/ 维护侧工作区,待部署) - registry-rehearsal.spec trust map 断言改为 production 命名闭集校验,四场景以 production key 重跑 6/6 - production release:preflight 通过;CHANGELOG R1 blocker 关闭并披露 ceremony 在维护者受控开发机完成
There was a problem hiding this comment.
🔵 Needs a closer look
It rotates a production signing trust key, and correctness/provenance of the new key material should be verified by a human maintainer before approval.
Pull request overview
This PR completes the R1 security release-blocker by rotating the registry publisher trust key from the rehearsal key to a production Ed25519 SPKI public key (ccb-publisher-2026-09), and updates tests/docs to reflect the new production trust map.
Changes:
- Rotates
REGISTRY_TRUSTED_PUBLIC_KEYSto the production publisher SPKI public key and removes the rehearsal key. - Updates the registry rehearsal unit test to validate the production trust map against non-production keyId naming.
- Updates
CHANGELOG.mdto record the key-rotation ceremony and close the related release blocker.
File summaries
| File | Description |
|---|---|
| tests/unit/scripts/registry-rehearsal.spec.ts | Adjusts trust-map assertions to ensure only non-rehearsal/test/dev-like keyIds are present and that entries are public keys. |
| src/main/services/registry-update-service.ts | Replaces the rehearsal trusted public key with the production publisher SPKI public key (ccb-publisher-2026-09). |
| CHANGELOG.md | Documents the production key ceremony, marks prior rehearsal-key notes as superseded, and closes the release blocker entry. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| it('production trust map 应包含 rehearsal publisher key', () => { | ||
| expect(REGISTRY_TRUSTED_PUBLIC_KEYS[DEFAULT_REHEARSAL_KEY_ID]).toMatch(/BEGIN PUBLIC KEY/) | ||
| expect(REGISTRY_TRUSTED_PUBLIC_KEYS[DEFAULT_REHEARSAL_KEY_ID]).not.toContain('PRIVATE KEY') | ||
| it('production trust map 应只包含 production 命名的 SPKI publisher key', () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R1 收尾:registry publisher key 从 rehearsal 轮换为 production(
ccb-publisher-2026-09),关闭 v1.5.0 最后一个发布阻塞项。Changes
REGISTRY_TRUSTED_PUBLIC_KEYS替换为 production SPKI public key(registry 与云模板通道共用;rehearsal key 移除)registry-rehearsal.spec.tstrust map 断言改为 production 命名闭集校验;四场景以 production key 重跑 6/6(CCB_REHEARSAL_KEY_ID=ccb-publisher-2026-09)tools/verify.cjs完整链 + 20/20 对抗自检通过,待上传 dev.niansir.comTesting
release:preflight通过(0 error / 0 warning)