fix(dkg): flanky test keymanager - #628
Open
iamquang95 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dkg::tests::verify_keymanager_connection_fails_for_unreachable_addressis flaky under parallel test runs. It binds127.0.0.1:0to get an ephemeral port, drops the listener, then connects expecting failure. Between release and connect, the kernel can hand the same port to another process (e.g. a concurrent test suite binding:0); since the production check is TCP-handshake-only, the connection succeeds and the test fails withunreachable keymanager should fail.Solution
Dial
http://127.0.0.1:0directly. Port 0 is only meaningful as a bind request ("assign me a port") and is never assigned to a listener, so as a connect destination it fails unconditionally — no probe-then-release window, no port for a competing process to occupy. Deterministic by construction; no retries, sleeps, or serialization. Test-only change; theDkgError::Keymanagerassertion is preserved.