Document phone extension field, simplify password warning - #264
Merged
Merged
Conversation
Contributor
|
DavidePrincipi
changed the title
Collapse the separate internal/external SMTP subsections into a single Recipient address section: the notification address always comes from the user's Email address field first, falling back to a Mail application bound to the user domain. This matches how notify-password-warning actually resolves the recipient and removes the outdated internal/external SMTP distinction. Also trim repeated "enable"/"enabled" wording in the surrounding prose for clarity. Assisted-by: Claude Code:claude-sonnet-5
Add the Phone extension field to both the Cluster Admin and User Management portal user forms, mirroring the existing Email entry; Active Directory and RFC2307 both store it in the LDAP telephoneNumber attribute. Rename "Email address" to Email to match the actual UI label, and expand its description: the attribute's meaning depends on the consuming application (login name, password warning recipient, or mail-domain alternate address), so point readers to the relevant sections instead of assuming a single use. Cross-link the User Management portal's field list back to Create users and groups so the two lists don't drift out of sync. Assisted-by: Claude Code:claude-sonnet-5
Mirror 114f7fa (docs(user_domains): simplify password expiration warning) in the Italian translation, per AGENTS.md's requirement to keep the i18n/it mirror in sync with the English page. Assisted-by: Claude Code:claude-sonnet-5
Mirror c5d3890 (docs(user_domains): document phone extension, align Email naming) in the Italian translation, per AGENTS.md's requirement to keep the i18n/it mirror in sync with the English page. Also drops the stray "(solo AD)" qualifier from "La password non scade mai", which never applied to that field in the English source. Assisted-by: Claude Code:claude-sonnet-5
DavidePrincipi
force-pushed
the
feat-8027
branch
from
September 17, 2026 11:08
55b2f3f to
177bad5
Compare
DavidePrincipi
marked this pull request as ready for review
September 17, 2026 11:11
DavidePrincipi
requested review from
andrea-marchionni,
gsanchietti and
nrauso
September 17, 2026 11:11
Use the Unicode em dash (—) instead of "--" in the CSV field list, matching the dash style already used elsewhere in the page. Add a note that the Phone extension field is not part of the CSV import/export format, to keep it compatible with files exported by earlier versions. Assisted-by: Claude Code:claude-sonnet-5
Mirror 8d060a6 (docs(user_domains): note CSV compatibility, use em dash in CSV list) in the Italian translation, per AGENTS.md's requirement to keep the i18n/it mirror in sync with the English page. Assisted-by: Claude Code:claude-sonnet-5
gsanchietti
reviewed
Sep 17, 2026
gsanchietti
left a comment
gsanchietti
left a comment
Member
There was a problem hiding this comment.
I'd change the first sentence (also in Italian): original one was a little bit more clear.
The Mail application bound to the user domain is not necessarily the one the cluster uses for its own notification submission; the MX requirement only drops when the two coincide. Spell out the two cases instead of unconditionally calling the submission internal. Assisted-by: Claude Code:claude-sonnet-5
Mirror df4fc14 (fix(user_domains): clarify when password warning needs a public MX) in the Italian translation, per AGENTS.md's requirement to keep the i18n/it mirror in sync with the English page. Assisted-by: Claude Code:claude-sonnet-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
telephoneNumberattribute, so the doc names a single attribute instead of one per schemaEmailfield description: its meaning depends on the consuming application (login name, password-warning recipient, or mail-domain alternate address), pointing to the relevant sections instead of assuming a single usenotify-password-warningactually resolves the recipient (user's Email field first, then a Mail application bound to the user domain)i18n/it) with all of the above, per AGENTS.md; also drops a stray "(solo AD)" qualifier on "La password non scade mai" left over from an earlier translationTest plan
yarn build(EN + IT)🤖 Generated with Claude Code