fix: better error management and socket.io-parser security bump - #218
Merged
Merged
Conversation
socket.io-parser 4.2.6 -> 4.2.7 closes the high-severity 'Socket.IO: Zero-attachment Memory Exhaustion' advisory. Transitive via @nethesis/phone-island > socket.io-client. Also resyncs the lockfile root entry with package.json: #217 left it declaring ^1.20.0/^7.88.0/^4.63.3 for axios/react-hook-form/rollup while package.json kept the original ^1.6.7/^7.50.1/^4.12.1 ranges. Resolved versions were unaffected, but the next npm install would have rewritten the file. Co-authored-by: Antonio <tonyco97.tc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #197
Closes #198
#197 — gestione errori
START_CALL_BY_URLIl controllo accettava solo
statusCode === 200e, in caso di errore, chiamavatriggerErrorma proseguiva comunque mostrando la PhoneIsland. Ora accetta 2xx e 302, e ritorna dopo l'errore. Commit originale di @tonyco97, autore preservato.#198 — socket.io-parser 4.2.6 → 4.2.7
Chiude l'advisory high severity Socket.IO: Zero-attachment Memory Exhaustion. Dipendenza transitiva via
@nethesis/phone-island>socket.io-client. Verificato connpm audit: l'advisory non compare più.Resync del lockfile
In #217 avevo ripristinato i range semver in
package.jsonsenza rigenerare il lock, lasciando il root entry del lockfile a dichiarare^1.20.0/^7.88.0/^4.63.3per axios/react-hook-form/rollup mentrepackage.jsonteneva^1.6.7/^7.50.1/^4.12.1.Le versioni risolte non erano interessate —
npm cifunzionava e la CI era verde — ma il primonpm installavrebbe riscritto il file in silenzio. Qui è risincronizzato sui range dichiarati inpackage.json, che è l'intento originale delle PR Renovate (erano lockfile-only).Verifica
npm ci+npm run buildverdi. Doponpm ciil lockfile resta invariato (git statuspulito), a conferma che la coerenza è ripristinata.