chore(deps): update dependency @electron-toolkit/eslint-config-prettier to v3 - #205
Closed
renovate[bot] wants to merge 1 commit into
Closed
renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
renovate
Bot
force-pushed
the
renovate/electron-toolkit-eslint-config-prettier-3.x
branch
from
August 26, 2026 10:54
9d676cf to
9a1375c
Compare
renovate
Bot
force-pushed
the
renovate/electron-toolkit-eslint-config-prettier-3.x
branch
from
September 18, 2026 08:45
9a1375c to
5e7a962
Compare
This was referenced Sep 18, 2026
edospadoni
added a commit
that referenced
this pull request
Sep 18, 2026
ESLint was entirely broken on main: .eslintrc.cjs extended 'react-app' and 'react-app/jest' while eslint-config-react-app was never installed, so 'npm run lint' failed before linting a single file. Rather than repair the eslintrc setup on eslint 8, this migrates to eslint 9 flat config, which also unblocks the two Renovate majors that were stuck on the 'eslint >= 9' peer requirement: - eslint ^8.56.0 -> ^9.39.5 - @electron-toolkit/eslint-config-ts ^1.0.1 -> ^3.1.0 (#206) - @electron-toolkit/eslint-config-prettier ^2.0.0 -> ^3.0.0 (#205) - eslint-plugin-react ^7.33.2 -> ^7.37.5 (flat config support) - eslint-plugin-react-hooks ^5.2.0 (was referenced, never installed) .eslintrc.cjs and .eslintignore are replaced by eslint.config.mjs. Config decisions: - React and react-hooks rules are scoped to src/renderer/**. The main process has plain functions named use* (useNethVoiceAPI, useLogin) that rules-of-hooks reported as hook violations in AccountController. - camelcase is off. Every one of its 41 reports was a snake_case field fixed by the backend API contract (speeddial_num, shared_groups, dst_cnam) or a theme token (extra_large, full_w). - react/prop-types is off, since TypeScript already checks props. - spaced-comment carries markers: ['/'] so --fix cannot mangle TypeScript triple-slash directives into '// / <reference ... />', which silently broke the vite/client types behind every .svg import. Beyond formatting, these lint errors needed real fixes: - useNethVoiceAPI.ts: drop the redundant async Promise executor around logout; the body already resolved unconditionally in finally, so behaviour is unchanged and no rejection path is lost. - logger.ts: replace the unsafe Function type with an explicit signature. - main.ts, Modal/index.tsx: merge duplicate imports. - AboutModule.tsx: drop the empty destructuring pattern. - usePresenceService.ts: drop an empty finally block. - ipcEvents.ts: document the intentionally silent catch in the drag path. - store.ts: move a // @ts-ignore next to the expression it suppresses. Reformatting split the statement it used to cover onto two lines, which silently un-suppressed a zustand typing error. 'npm run lint' now reports 0 errors and 339 warnings. typecheck and build are green, and the code merged from #192 and #213 is intact. Supersedes #215.
renovate
Bot
deleted the
renovate/electron-toolkit-eslint-config-prettier-3.x
branch
September 18, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^2.0.0→^3.0.0Release Notes
alex8088/electron-toolkit (@electron-toolkit/eslint-config-prettier)
v3.0.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.