Skip to content

Fixing uncataloged issue && copyright/SPDX headers - #72

Merged
hvinn merged 1 commit into
mainfrom
feature/console-local-ansible-playbooks-fit-finish
Aug 17, 2026
Merged

Fixing uncataloged issue && copyright/SPDX headers#72
hvinn merged 1 commit into
mainfrom
feature/console-local-ansible-playbooks-fit-finish

Conversation

@priyams-netapp

Copy link
Copy Markdown
Collaborator

Summary

Changes

Checklist

General

  • No secrets, credentials, or API tokens in code or config
  • New examples live under <tool>/<product>/ (e.g. python/ontap/), not at the tool root
  • Updated catalog.yaml — including product — and the product README for new/changed examples (see CONTRIBUTING.md)

If touching python/

  • Scripts compile (python -m py_compile python/*/*.py)
  • Lint passes (ruff check python/)

If touching ansible/

  • Syntax check passes (ansible-playbook --syntax-check)
  • ansible-lint passes

If touching terraform/

  • terraform fmt -check passes
  • terraform validate passes

If touching go/

  • go vet ./... passes (from go/ directory)
  • go build -o /dev/null . passes for the changed program

Test Report

Environment:
Platform version:
Style touched:

First run

Command + output
$ <command here>
<paste 10-50 lines of output, redact secrets>

Idempotency / re-run

Second-run evidence
$ <same command, run again>
<for ansible: PLAY RECAP must show changed=0>
<for terraform: `terraform plan` must show "No changes">
<for python: explain expected behavior on re-run>

Cleanup / teardown

Teardown evidence (skip for read-only examples)
$ <teardown command>
<paste output>

Cannot run on a cluster?

Related issues

@priyams-netapp
priyams-netapp requested a review from hvinn as a code owner August 17, 2026 14:51
@github-actions

Copy link
Copy Markdown

Thanks for your first PR to Pace — welcome aboard.

Quick orientation:

  1. CI runs in ~2 minutes. If anything fails, check the Actions tab — most failures have a one-line fix in docs/troubleshooting.md.
  2. If your PR touches python/, ansible/, or terraform/, you'll be asked for a Test Report. It's worth the effort — reviewers rely on it.
  3. Make sure the NetApp CCLA is on file before review.
  4. Stuck? Comment on this PR and a maintainer will jump in. We aim to respond as soon as possible.

For background, see CONTRIBUTING.md.

@github-actions

Copy link
Copy Markdown

Test Report missing or unfilled.

This PR touches python/, ansible/, terraform/, or go/, so a populated Test Report section is required in the PR body. See TESTING.md for what to capture (environment, platform version, first-run output, idempotency check, teardown).

This is a soft gate - your CI checks are unaffected - but reviewers will not approve until the report is filled in.

@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

A CI check failed — here is how to fix it

Workflow: PR Guard · Run #138 · Failed jobs: 1

commitlint

Commit message does not follow Conventional Commits. Required format:

<type>(<scope>): <description>

Valid types: build, chore, ci, doc, feat, fix, perf, refactor, revert, style, test. Valid scopes: python, ansible, terraform, go, ontap, console, docs, ci, deps.

To rewrite the last commit:

git commit --amend -m "feat(python): your description"
git push --force-with-lease

Push a fix and CI re-runs automatically; this comment updates with the next failure (or stays put if the same check fails again). Stuck? Comment on the PR and a maintainer will help — typical response time is 1 business day.

Auto-generated · explain-failure.yml

@hvinn hvinn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — the catalog registration and copyright/SPDX header fixes correctly resolve the gaps from #71 (validate-and-lint now passes).

Non-blocking follow-ups worth a look before/after merge:

  • commitlint is failing on the commit message (no Conventional Commits type/scope) — consider amending.
  • playbooks/user_registration.yml adds a debug task that echoes ncl_access_token in plaintext without no_log: true, unlike every other auth task in this feature — recommend guarding it.
  • 21 files got their mode flipped to 100755 (executable) — likely an editor artifact, probably worth reverting to 100644.
  • Ansible — syntax & lint and the CodeQL/go-vet 429s are unrelated infra flakiness/pre-existing issues, not blockers on this PR.

@hvinn
hvinn merged commit 061515d into main Aug 17, 2026
14 of 18 checks passed
@hvinn
hvinn deleted the feature/console-local-ansible-playbooks-fit-finish branch August 17, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants