Repository navigation
fix: disable statuscolumn for neogit buffers - #2034
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: user set values for 'statuscolumn' leak into neogit buffers.
Solution: reset 'statuscolumn'
Note that, in theory, 'statuscolumn' is set here:
neogit/lua/neogit/lib/buffer.lua
Lines 761 to 764 in aa99b44
But it doesn't seem to take effect, regardless of
config.status_column, because of how window-local options work: the option is set before assigning the window, here:neogit/lua/neogit/lib/buffer.lua
Lines 796 to 802 in aa99b44
Hence it's likely that this never worked.