Skip to content

Add test suites, harden metadata handling, and refactor for readability and cleanliness - #3

Merged
Nejaa merged 3 commits into
masterfrom
develop
Oct 11, 2026
Merged

Nejaa merged 3 commits into
masterfrom
develop

Conversation

@Nejaa

@Nejaa Nejaa commented Oct 11, 2026

Copy link
Copy Markdown
Owner

Correctness

  • Stop using the PDF CreationDate as the publication date
  • Bound decompressed ComicInfo.xml and archive member reads
  • Follow the ComicInfo v2.0 element order and Year/Month/Day date fields
  • Allow clearing the CBZ rating
  • Strip trailing separators from inferred titles
  • Keep names containing commas intact in list-valued editor fields

Tests

  • Add suites for the app HTTP workflows, catalog parsing and ranking, library inference, metadata formats, settings, store and migrations
  • Build fixtures from format standards (EPUB, ComicInfo, ISBN)

Refactoring

  • Split high-complexity functions (search, drafts, ranking, EPUB and CBZ processing) into focused helpers
  • Replace the long parameter list in search with a searchTarget struct
  • Rework the OCR, desktop packaging and release scripts, the Dockerfile and platform hooks to resolve static-analysis findings

Documentation

  • Add package and identifier doc comments and comments explaining the intent of non-obvious algorithms
  • Fix stale or misplaced comments
  • Rewrite the README as end-user documentation

Nejaa added 2 commits October 11, 2026 11:27
Correctness
- Stop using the PDF CreationDate as the publication date
- Bound decompressed ComicInfo.xml and archive member reads
- Follow the ComicInfo v2.0 element order and Year/Month/Day date fields
- Allow clearing the CBZ rating
- Strip trailing separators from inferred titles
- Keep names containing commas intact in list-valued editor fields

Tests
- Add suites for the app HTTP workflows, catalog parsing and ranking,
  library inference, metadata formats, settings, store and migrations
- Build fixtures from format standards (EPUB, ComicInfo, ISBN)

Refactoring
- Split high-complexity functions (search, drafts, ranking, EPUB and CBZ
  processing) into focused helpers
- Replace the long parameter list in search with a searchTarget struct
- Rework the OCR, desktop packaging and release scripts, the Dockerfile and
  platform hooks to resolve static-analysis findings

Documentation
- Add package and identifier doc comments and comments explaining the
  intent of non-obvious algorithms
- Fix stale or misplaced comments
- Rewrite the README as end-user documentation
- Dockerfile: escape the dpkg-query format string (\t, \n) so the RUN
  instruction is no longer split by a literal newline; normalize line
  continuations, indentation and LABEL layout
- main: close the HTTP server on every return path
- consent_other: mark unused desktopConsent parameters
- ocrruntime tests: compare with errors.Is(err, context.Canceled)
- metadata tests: replace defer-in-loop with a comicInfoMember helper
- Apply IDE cleanups
@Nejaa Nejaa changed the title Add test suites, harden metadata handling, and refactor for readability Add test suites, harden metadata handling, and refactor for readability and cleanliness Oct 11, 2026
@Nejaa
Nejaa requested a balanced review from Copilot October 11, 2026 10:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Nejaa
Nejaa requested a balanced review from Copilot October 11, 2026 10:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Nejaa
Nejaa merged commit 2002e8a into master Oct 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants