Repository navigation
Conversation
Correctness - Stop using the PDF CreationDate as the publication date - Bound decompressed ComicInfo.xml and archive member reads - Follow the ComicInfo v2.0 element order and Year/Month/Day date fields - Allow clearing the CBZ rating - Strip trailing separators from inferred titles - Keep names containing commas intact in list-valued editor fields Tests - Add suites for the app HTTP workflows, catalog parsing and ranking, library inference, metadata formats, settings, store and migrations - Build fixtures from format standards (EPUB, ComicInfo, ISBN) Refactoring - Split high-complexity functions (search, drafts, ranking, EPUB and CBZ processing) into focused helpers - Replace the long parameter list in search with a searchTarget struct - Rework the OCR, desktop packaging and release scripts, the Dockerfile and platform hooks to resolve static-analysis findings Documentation - Add package and identifier doc comments and comments explaining the intent of non-obvious algorithms - Fix stale or misplaced comments - Rewrite the README as end-user documentation
- Dockerfile: escape the dpkg-query format string (\t, \n) so the RUN instruction is no longer split by a literal newline; normalize line continuations, indentation and LABEL layout - main: close the HTTP server on every return path - consent_other: mark unused desktopConsent parameters - ocrruntime tests: compare with errors.Is(err, context.Canceled) - metadata tests: replace defer-in-loop with a comicInfoMember helper - Apply IDE cleanups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctness
Tests
Refactoring
Documentation