feat: --pr names the pull request a detached checkout cannot, and the inbox passes it - #87
Merged
Conversation
… inbox passes it A session the inbox opened had no pull request: the worktree is detached at the PR head, so `gh pr view` for the current branch found nothing, the details endpoint answered null, and the page showed an empty bar where the description, reviews and submit dialog belong. `diffity --pr <number> <base>` hands the server the number directly and pins /diff to the base, as the URL flow does; the inbox spawns its sessions that way, with the number from the store row. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
… and its wiring is tested The check ran before --base/--compare were folded into the refs, so `--pr 5 --base X` was refused with a message asking for what --base had supplied. A repository with no GitHub remote is refused up front, as the URL flow does, instead of accepting a number that could show nothing. The tests now start the entry with --pr and check the pinned redirect. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A session opened from the inbox showed no GitHub controls. Its worktree is detached at the PR head, so the server's
gh pr viewfor the current branch found nothing and/api/github/detailsanswered null; the page rendered an empty bar where the description, reviews and submit dialog belong.diffity --pr <number> <base>: names the pull request when the checkout cannot. Needs exactly one ref (the base the PR is against), refuses a working-tree ref, and cannot be combined with a PR URL. Like the URL flow, it pins/diffto that base.--pr <store row number>./diffredirects to the pinned base.An inbox session started by the previous build keeps being reused by
/openuntil it is stopped once; the daemon also needs a restart to pass the flag.Bumps to 0.10.13.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w