Repository navigation
NWAC Mountain Forecast UI Update - #1279
Open
kevinherdez wants to merge 2 commits into
Open
kevinherdez wants to merge 2 commits into
kevinherdez wants to merge 2 commits into
Conversation
Collaborator
|
Awesome work! Excited to see this refreshed weather look in the app! Looking at this on my phone I was going to suggest doing aligning of some of the column elements, but @rchlfryn let me know what you think, I am usually UX challenged :D I think the starting potin for eve/Night should be the same for the columns (or maybe the end is the same, anyways just the alignment more clean |
yuliadub
reviewed
Nov 20, 2026
| } | ||
|
|
||
| if (metadata?.widget_config.stations?.token) { | ||
| if (incompleteQueryState(weatherStationsResult) || !weatherStations) { |
Collaborator
There was a problem hiding this comment.
this wont load the forecast if the weather station api is down (but forecast has data), I think we have always done it that way but I had a thought maybe we want to load the forecast and print an error message for the weather stations? not a blocker just came to my mind so figured I'd share 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




@rchlfryn got guidance that mobile should match the mobile web version of the mountain weather forecast as best as possible.
Main Changes
Deviations from Web
nwacWeatherWindowfrom web. However, that file usesTZDate()from@date-fns/tz. While we pull indate-fns-tz, it's an older version that does not contain that type. I replicated the intent ofTZDatewith what we had available to not bring in a new package so that we can release this OTA. As a part of the Expo 58 PR that's open I can add the package and make a 1:1 match of webPR Lay out
NWACWeatherTabcode into separate files to make them easier to reason about. The first commit has all of the changes related to the UI changes, and the second commit has the new files.Screenshots
Before full tab UI
After full tab UI
Multi station
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.