Repository navigation
Move NWACs mountain weather to the new endpoint - #1273
Merged
Merged
Conversation
rchlfryn
reviewed
Nov 9, 2026
rchlfryn
left a comment
There was a problem hiding this comment.
Nice work on this, and the fixture-backed tests are really helpful. Three things need fixing before this merges: the 24-hour window and snow tooltip (inline), plus the staging host below.
Must fix: the staging nwacHost in clientContext.ts is still https://staging.nwac.us. That resolves to the old EC2 host and fails TLS, so staging mode can’t reach /api/nwac/nwac-weather-zone. This needs to point at the AvyWeb environment that serves this route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the new NWAC mountain weather endpoint.
Overview
This is a feature that's on web that we need to match on mobile. The formatting code that's used on the table is a direct copy from web. The table UI is largely the same but modified to better fit a mobile interface
Copied code
These files are a direct copy from web. To keep them in sync we might want to consider creating a CI pipeline so when changes happen on web they're picked up on mobile.
nwacWeather.tsnwacWeatherFormat.tsUI
NWACWeatherTab.tsxis the new home for the NWAC specific weather table. Before this lived inWeatherTab.tsx. NowWeatherTab.tsxis the NAC style table.The main difference in UI between web and the app is that the app is showing different days as their own cards with tables in the cards for Day and Night forecasts. Web shows all of this in 1 table with a different column for each day and night forecast.
Other difference:
Testing
I tested this on the iOS sim and Android device
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.