fix: incorrect kernel launching parameter in parallel_for_gpu_soa - #537
Open
XDflight wants to merge 1 commit into
Open
fix: incorrect kernel launching parameter in parallel_for_gpu_soa#537XDflight wants to merge 1 commit into
parallel_for_gpu_soa#537XDflight wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect CUDA kernel launch configuration in parallel_for_gpu_soa by using the intended 2D grid (x = n_blocks_linear(n_elements), y = n_dims) so the kernel can correctly index both elements and dimensions via blockIdx.x and blockIdx.y.
Changes:
- Use the precomputed
dim3 blocks = { n_blocks_linear(n_elements), n_dims, 1 }when launchingparallel_for_soa_kernel. - Ensure the launch grid matches the kernel’s indexing scheme (
blockIdx.yfor dimension selection).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like a typo to me. I found this issue while debugging a program that uses
parallel_for_gpu_soa.