Skip to content

fix: test calls undefined get_desired_rpy instead of get_franka_rpy - #21

Open
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/metrics-features-utils-test-60d38428
Open

fix: test calls undefined get_desired_rpy instead of get_franka_rpy#21
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/metrics-features-utils-test-60d38428

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Jul 27, 2026

Copy link
Copy Markdown

Problem

fix: test calls undefined get_desired_rpy instead of get_franka_rpy

Fix

Replace:

    _, rpy_actual = utils.metrics_features_utils.get_desired_rpy(reorient_quat, grasp_quat)

with:

    _, rpy_actual = utils.metrics_features_utils.get_franka_rpy(grasp_quat)

Files changed

  • tests/utils/metrics_features_utils_test.py

@andrewwhitecdw
andrewwhitecdw marked this pull request as ready for review August 3, 2026 22:07
@andrewwhitecdw

Copy link
Copy Markdown
Author

Closing this sweep-generated PR: PR has 2 commits; sweep requires exactly one commit per PR. It does not meet the sweep requirements (single signed-off commit).

Signed-off-by: Andrew White <andrewwhitecdw@users.noreply.github.com>
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@andrewwhitecdw
andrewwhitecdw force-pushed the bugfix/metrics-features-utils-test-60d38428 branch from 6f4a4cf to 87f7c22 Compare August 18, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant