Add missing <vector> include in libdispatch_queue.hpp - #2160
Open
mikomikotaishi wants to merge 1 commit into
Open
Add missing <vector> include in libdispatch_queue.hpp#2160mikomikotaishi wants to merge 1 commit into
<vector> include in libdispatch_queue.hpp#2160mikomikotaishi wants to merge 1 commit into
Conversation
<vector> include in libdispatch_queue.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exec/libdispatch_queue.hppusesstd::vector(line 443 upstream, line 444 after my edits), but never includes<vector>. Although this typically arrives transitively throughstdexec/execution.hpp, on libc++ 22, the include appears on C++23 but does not in C++26.stdexec/execution.hppalready includes the otherstdsymbols used in this file transitively, but notstd::vector.Result:
This, however, passes with
-std=c++23.This header only gets included on Apple platforms, and Linux/libstdc++ never compiles it. (I observed this on Homebrew LLVM clang 22.1.8 and bundled libc++, on macOS.)
The fix is simply adding
#include <vector>.