Skip to content

asioexec::completion_token: Fix Miscompiling Test #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericniebler merged 1 commit into from
Aug 7, 2026
+13 −24
Merged

asioexec::completion_token: Fix Miscompiling Test #2155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 13 additions & 24 deletions test/exec/asio/test_completion_token.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@
using namespace STDEXEC;
using namespace exec::asio;

#if STDEXEC_GCC() && STDEXEC_GCC_VERSION >= 1400 && STDEXEC_GCC_VERSION < 1500
// Work around a GCC 14 IPA mod/ref miscompilation in this test.
# pragma GCC optimize("no-ipa-modref")
#endif

namespace
{

Expand Down Expand Up @@ -354,36 +359,20 @@ namespace
std::shared_ptr<void>& ptr,
CompletionToken&& token)
{
// This function is seemingly fragile?
//
// In release mode slightly different arrangements produce bizarre outcomes:
//
// /root/stdexec/test/asioexec/test_completion_token.cpp:380: FAILED:
// CHECK( !ex )
// with expansion:
// false
//
// /root/stdexec/test/asioexec/test_completion_token.cpp:382: FAILED:
// CHECK( ptr.use_count() == 1U )
// with expansion:
// -1564306560 == 1
using signature_type = void();
return asio_impl::async_initiate<CompletionToken, signature_type>(
[&ptr](auto h, auto const & ex)
{
auto local = std::make_shared<decltype(h)>(std::move(h));
auto const assoc = asio_impl::get_associated_executor(*local, ex);
ptr = local;
asio_impl::post(assoc,
[&ptr, local = std::move(local)]() mutable
{
CHECK(local.use_count() == 2);
CHECK(ptr.use_count() == 2);
auto cpy = std::move(local);
cpy.reset();
CHECK(ptr.use_count() == 1);
throw std::logic_error("Test");
});
asio_impl::post(ex,
asio_impl::bind_executor(assoc,
[local]() mutable
{
local.reset();
throw std::logic_error("Test");
}));
},
token,
ex);
Expand All @@ -394,7 +383,7 @@ namespace
"completion handler's lifetime (this is necessary in situations where "
"asynchronous control flow bifurcates and one of the child operations ends "
"via exception)",
"[asioexec][completion_token][!mayfail]")
"[asioexec][completion_token]")
{
std::exception_ptr ex;
std::shared_ptr<void> ptr;
Expand Down
Loading