fail fast when FabricManager fails to come up - #908
Merged
Conversation
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
fail-fast-on-fm-fail
branch
from
August 5, 2026 17:42
d7d5c6c to
223687f
Compare
rajathagasthya
approved these changes
Aug 5, 2026
Contributor
|
Looks good to me as well! This needs a good amount of testing to make sure there are no spurious failures with some of these daemons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, the driver containers go into
Runningmode even if Fabric Manager doesn't come up successfully. Given that Fabric Manager is a must-have for GPUs to be usable in NVSwitch-based nodes, the driver container should fail fast instead. This would make it easier for users to debug any driver container issues relating to Fabric Manager as they get immediate feedback