chore(ci): update skills - #214
Open
coryrylan wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
scope(ci)
scope(internals)
scope(cli)
dependencies
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChangesThe changes add a component project scaffolding CLI and integration checklist. They also update upkeep, build, lint, pre-commit, agent isolation, Git LFS, and dependency notice guidance. Repository tooling and guidance
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Author
participant ScaffoldCLI
participant Repository
participant NewProject
Author->>ScaffoldCLI: provide project name, reference, and description
ScaffoldCLI->>Repository: read tracked reference files and integration targets
ScaffoldCLI->>NewProject: create normalized project files
ScaffoldCLI->>Repository: update workspace, CI, site, metadata, lint, and Knip configuration
ScaffoldCLI-->>Author: report planned or applied changes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/agent-upkeep/SKILL.md:
- Line 141: Update the verification guidance around the “Done when” criterion
and the commands in the verification section to consistently cover all
applicable project scripts, including optional test:lighthouse and test:visual
invocations, or narrow the completion criterion to only the listed commands.
Ensure users cannot satisfy the procedure while omitting suites that the
repository guidance identifies as applicable.
In @.agents/skills/authoring-documentation/SKILL.md:
- Line 31: Update the Pre-commit bullet in the documentation to insert a space
after the colon, so the text reads “lint-staged): automatically” while
preserving the rest of the wording.
In @.agents/skills/authoring-projects/scripts/scaffold-project.mjs:
- Around line 20-22: Update the description validation in scaffold-project’s
argument-validation flow to reject values containing the JSDoc terminator
sequence */ before file planning or generation. Preserve the existing
single-line check and fail through the established fail validation path with a
clear --description error.
- Around line 392-406: Update the catch block in applyChanges to remove every
path from changesToApply that is absent from originals, while retaining
restoration of existing files and projectDirectory cleanup. Add a regression
test that forces a write failure after the documentation page is created and
verifies the newly created page is removed.
In @.agents/skills/authoring-projects/SKILL.md:
- Around line 41-48: The verification checklist in
.agents/skills/authoring-projects/SKILL.md lines 41-48 must include the metadata
generation command alongside the existing project checks. Update the next-step
output in .agents/skills/authoring-projects/scripts/scaffold-project.mjs lines
65-68 to instruct users to run metadata generation before final verification.
- Line 50: Update the CI guidance in the numbered workflow step so it explicitly
distinguishes changes requiring broader CI from changes covered by project-local
checks: require broader CI for changes affecting shared infrastructure, build or
release configuration, cross-project interfaces, generated artifacts, or
multiple packages, while allowing targeted project checks for isolated changes.
Preserve the existing final-diff inspection requirements and follow the
repository’s technical writing style.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: b1a785a0-94a7-406c-ac04-579cb464f94d
📒 Files selected for processing (12)
.agents/hooks/pre-tool-use-bash.sh.agents/skills/agent-upkeep/SKILL.md.agents/skills/authoring-documentation/SKILL.md.agents/skills/authoring-projects/SKILL.md.agents/skills/authoring-projects/references/integration-checklist.md.agents/skills/authoring-projects/scripts/scaffold-project.mjs.agents/skills/guidance-build-system/SKILL.md.husky/pre-commitNOTICE.mdpackage.jsonprojects/cli/NOTICE.mdprojects/internals/BUILD.md
coryrylan
force-pushed
the
topic-skill-fixes
branch
from
August 12, 2026 13:42
2c90408 to
5e25555
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/agent-upkeep/SKILL.md:
- Around line 170-191: Update the Verification section in SKILL.md to enforce
complete CI: run the repository-root `mise exec -- pnpm run ci`, or document an
equivalent command set covering all root and project checks. For Mode A, ensure
the verification commands run from every selector-provided
`packages[].workingDirectory`, not only one project, while preserving the
instruction to record absent scripts and stop on visual-test failures.
In @.agents/skills/authoring-projects/scripts/scaffold-project.mjs:
- Around line 22-23: Update the --description validation near the existing
newline checks in scaffold-project.mjs to reject carriage returns as well as LF
characters, preserving the single-line contract before the description is
written into the generated JSDoc.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 45a324d4-24f4-4c66-a517-db08956f7c56
📒 Files selected for processing (4)
.agents/skills/agent-upkeep/SKILL.md.agents/skills/authoring-documentation/SKILL.md.agents/skills/authoring-projects/SKILL.md.agents/skills/authoring-projects/scripts/scaffold-project.mjs
Comment on lines
+22
to
+23
| if (description.includes('\n')) fail('--description must be a single line.'); | ||
| if (description.includes('*/')) fail('--description must not contain "*/".'); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Reject carriage returns in --description.
Line 22 rejects only LF. A value with a standalone \r passes validation and creates an additional physical line when Line 172 writes the JSDoc. This can alter generated JSDoc tags and violates the single-line description contract.
Proposed fix
-if (description.includes('\n')) fail('--description must be a single line.');
+if (/[\r\n]/u.test(description)) fail('--description must be a single line.');📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if (description.includes('\n')) fail('--description must be a single line.'); | |
| if (description.includes('*/')) fail('--description must not contain "*/".'); | |
| if (/[\r\n]/u.test(description)) fail('--description must be a single line.'); | |
| if (description.includes('*/')) fail('--description must not contain "*/".'); |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.agents/skills/authoring-projects/scripts/scaffold-project.mjs around lines
22 - 23, Update the --description validation near the existing newline checks in
scaffold-project.mjs to reject carriage returns as well as LF characters,
preserving the single-line contract before the description is written into the
generated JSDoc.
johnyanarella
requested changes
Aug 13, 2026
coryrylan
force-pushed
the
topic-skill-fixes
branch
4 times, most recently
from
August 13, 2026 13:14
537421d to
6d4214e
Compare
- fix missing skill details - align pre commit hooks to pnpm scripts - fix agent cloud env var - add project authoring skill for standing up new projects Signed-off-by: Cory Rylan <crylan@nvidia.com>
coryrylan
force-pushed
the
topic-skill-fixes
branch
from
August 13, 2026 13:16
6d4214e to
87c0817
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores