Conversation
Pass the canonical host buffer directly to SHA-256 and Base64. Retain the exact receipt format while avoiding a full-size byte copy. Signed-off-by: Trent Nelson <trentn@nvidia.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publishing xScan scientific evidence copies the complete packed float64 array solely to feed SHA-256 and Base64. Pass a view of the canonical NumPy buffer to both consumers, avoiding that temporary allocation and copy while preserving the encoded payload, checksum, counts and receipt format.
CPU regression tests compare the complete receipt for contiguous and strided read-only inputs, including signed zeros, infinities and distinct NaN bit patterns.
Validation
uv lock --checkand all repository pre-commit checks pass.make lintpasses.make test-cpu: 2,789 passed, 210 skipped (GPU, optional backends and observational data); 40 expected Astropy FITS-keyword warnings.Repository hygiene