Repository navigation
Conversation
The uv command already installs the wheel by path, but pip still passed --no-index, which makes it resolve numpy, pyyaml and every extra from install/wheels/, so the documented command fails in a fresh venv. Install the wheel by path with pip too, keeping --find-links for the isaacteleop transition wheel. Pick the wheel tag from the active Python instead of hardcoding cp312, which misses the default 3.11 build. references/build.rst gets the same tag, and its bare pip glob, which cannot find the transition wheel and breaks once install/wheels/ holds more than one build, now uses that path. Signed-off-by: Ivan Yang <yifanyang@nvidia.com> (cherry picked from commit b389725)
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
A local build is always X.Y+local, so pinning that version installs it with plain pip and uv commands: the resolver picks the wheel for the venv's Python, skips older builds left in install/wheels/, and cannot prefer a newer published release. This replaces the ls/python lookup that selected a wheel path, matching how InstallPythonExample.cmake pins the installed examples. Signed-off-by: Ivan Yang <yifanyang@nvidia.com> (cherry picked from commit 9390e71)
jiwenc-nv
approved these changes
Oct 17, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #1179 (
b38972532bf92d480775960520fda8b7c2612ece,9390e7199890312f6824f7946bc35c13d1feaec1) intorelease/1.6.x.Build from Source step 4 installed the source-built wheel with
pip install "isaaccapture[...]" --find-links=./install/wheels/ --no-index, which cannot resolve the wheel's dependencies in a fresh venv. Both pages now pin the local build's version, which is alwaysX.Y+local:The pin selects the wheel for the venv's Python, skips older builds in
install/wheels/, and keeps a published release from replacing the local one;--find-linkssupplies theisaacteleoptransition wheel. Applied without conflicts; both files matchedmainbefore the change, so the patch is identical to #1179.-6597739
Validation: all-files pre-commit passed with
SKIP=check-copyright-year; strictmake current-docspassed.