Repository navigation
Restore dashboard creation in View mode - #47
Merged
Merged
Conversation
Dashboard authoring persists visualizations without modifying monitored infrastructure. Restore both dashboard tools to the View policy and document this intentional exception so future safety changes preserve it. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore dashboard_create and grafana_dashboard_create in View mode, reversing the restriction introduced by e22a9fb. Dashboard authoring saves visualizations of observed data without modifying monitored workloads or infrastructure, so it belongs in the View workflow even though Grafana persists the dashboard. Add a code comment documenting that policy and a regression test verifying both dashboard tools are permitted while infrastructure mutations still require Edit.