Add ekore_py by AkshatRai07 · Pull Request #554 · NNPDF/eko

AkshatRai07 · 2026-07-21T20:22:29Z

A step for #519
In this PR we:

ekore_py crate, which exposes ekore crate using PyO3 and build the lib using maturin.
Expose anomalous_dimensions and operator_matrix_elements as Python functions.

TODO

AkshatRai07 · 2026-07-21T20:23:23Z

Doubt, what should we name this python library?

Copilot

Pull request overview

Adds a new ekore_py crate intended to provide Python bindings for ekore via PyO3, and wires it into the workspace/release metadata while updating crate READMEs to reference the new component.

Changes:

Introduces a new crates/ekore_py package with an initial PyO3 module scaffold plus Python packaging metadata (pyproject.toml).
Adds pyo3 to workspace dependencies and updates Cargo.lock accordingly.
Updates framework documentation and release crate list to include ekore_py.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
crates/release.json	Adds `ekore_py` to the crate release list.
crates/ekore/README.md	Mentions the new `ekore_py` crate in the framework list.
crates/ekore_py/src/lib.rs	Adds initial PyO3 module scaffold (currently a template function).
crates/ekore_py/README.md	Introduces README for the Python binding crate.
crates/ekore_py/pyproject.toml	Adds maturin-based Python build metadata for `ekore_py`.
crates/ekore_py/Cargo.toml	Adds new Rust crate manifest for the PyO3 cdylib.
crates/ekore_capi/README.md	Mentions `ekore_py` in the framework list.
crates/eko/README.md	Mentions `ekore_py` in the framework list.
crates/dekoder/README.md	Mentions `ekore_py` in the framework list.
Cargo.toml	Adds `pyo3` to workspace dependencies.
Cargo.lock	Updates lockfile format/version and adds PyO3 dependency graph entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

felixhekhorn · 2026-07-22T08:39:01Z

Doubt, what should we name this python library?

I guess there are two options: ekore_py (as in PineAPPL https://github.com/NNPDF/pineappl/tree/master/pineappl_py ) or ekore_pyapi (as in NeoPDF https://github.com/QCDLab/neopdf/tree/master/neopdf_pyapi) - I'm fine with either ... maybe the latter is slightly more consistent?

AkshatRai07 · 2026-07-22T11:55:31Z

The crate name will be ekore_py only, I was asking the name of the python library. For eg. it's the eko crate but the python project is eko-rs (hence pip install eko-rs) and library is ekors (hence import ekors). For neopdf_pyapi it's neopdf-hep and neopdf, for pineappl_py it is pineappl and pineappl (both are same).

felixhekhorn · 2026-08-05T15:39:46Z

The crate name will be ekore_py only, I was asking the name of the python library. For eg. it's the eko crate but the python project is eko-rs (hence pip install eko-rs) and library is ekors (hence import ekors). For neopdf_pyapi it's neopdf-hep and neopdf, for pineappl_py it is pineappl and pineappl (both are same).

I see, mmm ... I've no strong opinion ... - can not be in a Python module name of course, that's why it has to be ekors ... should we harmonize that (for eko) or we don't care? should we then follow that naming convention here, i.e. pip install ekore-rs and import ekorers? I think we should avoid the plain ekore since that is already taken by the existing eko package ... also ekore_py is just fine to me (e.g. also numpy as an explicit "py" in the name)

AkshatRai07 · 2026-08-06T08:04:16Z

So in my opinion we should not add the -py prefix, someone new to the ecosystem may get confused between ekore and ekorepy as which is the correct one and the difference between the two. In my opinion we should name the project ekore-rs and the library ekore_rs. This name conveys it is the Rust version of the library, and the underscore in library name makes it less confusing compared to ekorers. Works?

felixhekhorn · 2026-08-11T10:41:19Z

+      - name: Setup Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ vars.PYTHON_VERSION_WORKFLOWS }}
+      - name: Setup Rust toolchain
+        uses: dtolnay/rust-toolchain@stable
+      - name: Create virtual environment
+        run: python -m venv .venv
+      - name: Add venv to PATH
+        run: echo "$PWD/.venv/bin" >> "$GITHUB_PATH"
+      - name: Install task runner and test deps
+        run: pip install maturin numpy poethepoet pytest


do we need venv? can't we rely on the global environment?

should we pin the versions here?

if the answer to the last is yes: we should cache the environment Caching data in workflows is not working #452

felixhekhorn · 2026-08-11T10:47:00Z

+        let gamma = $path($order_qcd, $mode, &mut cache.inner, $nf);
+        gamma_ns_qcd_body!(@collect $py, $order_qcd, gamma)
+    }};
+    (@check $order_qcd:expr, $mode:expr, $bound:expr) => {


Suggested change

(@check $order_qcd:expr, $mode:expr, $bound:expr) => {

// sanity checks

(@check $order_qcd:expr, $mode:expr, $bound:expr) => {

maybe add a few more comments, these macro expansions look a bit scary 🙃

felixhekhorn · 2026-08-11T10:47:35Z

+            )));
+        }
+    };
+    (@collect $py:expr, $order_qcd:expr, $gamma:expr) => {{


Suggested change

(@collect $py:expr, $order_qcd:expr, $gamma:expr) => {{

// transform for return

(@collect $py:expr, $order_qcd:expr, $gamma:expr) => {{

felixhekhorn · 2026-08-11T10:49:47Z

@@ -0,0 +1,216 @@
+//! Shared bodies for the `#[pyfunction]`s defined throughout this crate.
+
+/// Body for a non-singlet tower function returning shape `(order_qcd,)`.


Suggested change

/// Body for a non-singlet tower function returning shape `(order_qcd,)`.

/// Body for a non-singlet tower function.

/// Returning shape: `(order_qcd,)`.

maybe?

felixhekhorn · 2026-08-11T10:50:23Z

+
+/// Body for a non-singlet tower function returning shape `(order_qcd,)`.
+macro_rules! gamma_ns_qcd_body {
+    // With an `n3lo_variation` argument.


Suggested change

// With an `n3lo_variation` argument.

// Compute with an `n3lo_variation` argument.

Init commit

4e3562a

Copilot AI review requested due to automatic review settings July 21, 2026 20:22

Copilot started reviewing on behalf of AkshatRai07 July 21, 2026 20:22 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Comment thread crates/ekore_py/README.md Outdated

Comment thread crates/ekore_py/Cargo.toml Outdated

Comment thread crates/ekore_py/Cargo.toml

Comment thread crates/ekore_py/src/lib.rs Outdated

Comment thread crates/ekore_py/src/lib.rs Outdated

AkshatRai07 added 5 commits July 22, 2026 12:15

Add constants

da1f566

Add constants tests

5215f4f

Add CI

e8d580e

Fix README

8afef9f

Linked doc-header

688d5d2

felixhekhorn added enhancement New feature or request rust Rust extension related gsoc26 labels Jul 22, 2026

felixhekhorn marked this pull request as draft July 22, 2026 08:35

AkshatRai07 added 13 commits July 22, 2026 19:38

Added ad_ps and Cache

2823918

Added ad_ps tests

e988dd3

Added ad_us

f4cf839

Added ad_us tests

07a5bb4

Added ome_us

ce5becf

Added ome_us tests

601ce5c

Added header docs

8b2d604

Added macros to remove code duplication

674cd1f

Fixed numpy module error

7b6ae24

Added CD for pyapi

ec2cb73

Updated Changelog

9d53214

Added MacOS in tests

5cdc0af

Merge branch 'master' into ekore-py

ca1b100

felixhekhorn marked this pull request as ready for review August 5, 2026 15:39

felixhekhorn and others added 3 commits August 6, 2026 13:21

Update README.md

9b80248

Changed lib and project name

ce9a0e0

Update ekore-rs in README

d0ecfd5

felixhekhorn reviewed Aug 11, 2026

View reviewed changes

felixhekhorn mentioned this pull request Aug 11, 2026

GSoC 26 #515

Open

	(@check $order_qcd:expr, $mode:expr, $bound:expr) => {
	// sanity checks
	(@check $order_qcd:expr, $mode:expr, $bound:expr) => {

	(@collect $py:expr, $order_qcd:expr, $gamma:expr) => {{
	// transform for return
	(@collect $py:expr, $order_qcd:expr, $gamma:expr) => {{

		@@ -0,0 +1,216 @@
		//! Shared bodies for the `#[pyfunction]`s defined throughout this crate.

		/// Body for a non-singlet tower function returning shape `(order_qcd,)`.

	/// Body for a non-singlet tower function returning shape `(order_qcd,)`.
	/// Body for a non-singlet tower function.
	/// Returning shape: `(order_qcd,)`.

	// With an `n3lo_variation` argument.
	// Compute with an `n3lo_variation` argument.

Uh oh!

Conversation

AkshatRai07 commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

AkshatRai07 commented Jul 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

felixhekhorn commented Jul 22, 2026

Uh oh!

AkshatRai07 commented Jul 22, 2026

Uh oh!

felixhekhorn commented Aug 5, 2026

Uh oh!

AkshatRai07 commented Aug 6, 2026

Uh oh!

felixhekhorn Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

felixhekhorn Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

felixhekhorn Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

felixhekhorn Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

felixhekhorn Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AkshatRai07 commented Jul 21, 2026 •

edited

Loading

felixhekhorn Aug 11, 2026 •

edited

Loading