test: put in some bad stuff to test sonarqube

[hatwell]

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-7116

---

📄 Description/Summary of Changes

• Testing sonarqube's ability to flag issues in code

---

🧪 Developer Testing Carried Out

---

📋 PR Principles

• Keep PRs Small and Focused: Ensure the PR addresses a single task or feature to make it easier to review.
• Multiple PRs for one Ticket: When splitting work into multiple PRs, clearly describe what this PR addresses and outline the remaining work to complete the ticket.
• Ensure Tests Are Included: Add or update unit, integration, or end-to-end tests to cover the changes made.
• Follow Coding Standards: Ensure the code adheres to the team's coding guidelines and best practices.
• Resolve Comments Promptly: If you raise a comment, ensure you follow up and resolve it before approving the PR to maintain clarity and ensure comments are addressed.
• Foster Learning: PR reviews are an opportunity to share knowledge, provide constructive feedback, and encourage a collaborative environment.

🏷️ Naming Conventions Reminder

Please ensure the following naming conventions are followed:

• PR title follows the format: NPA-XXXX: <short-description>
• Branch name follows the convention: <type>/NPA-XXXX/<short-description>
• Commit messages follow the template: NPA-XXXX: <short-description>

[Copilot]

Pull request overview

This PR introduces deliberately “bad” patterns intended to test SonarQube’s ability to detect issues within the sandbox API codebase and its unit tests.

Changes:

• Adjusted assertion operand ordering in two sandbox API test modules.
• Added a hard-coded token constant to sandbox/api/constants.py.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
sandbox/api/tests/test_patch_consent.py	Reordered a JSON equality assertion in the PATCH consent test.
sandbox/api/tests/test_get_questionnaire_response_by_path_id.py	Reordered a status code assertion in the QuestionnaireResponse GET test.
sandbox/api/constants.py	Added a new constant containing a hard-coded token.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud