Skip to content

Fix/update fhir url to https - #387

Open
hatwell wants to merge 3 commits into
masterfrom
fix/update-fhir-url-to-https
Open

Fix/update fhir url to https#387
hatwell wants to merge 3 commits into
masterfrom
fix/update-fhir-url-to-https

Conversation

@hatwell

@hatwell hatwell commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-0000

📄 Description/Summary of Changes


🧪 Developer Testing Carried Out


📋 PR Principles

  • Keep PRs Small and Focused: Ensure the PR addresses a single task or feature to make it easier to review.
  • Multiple PRs for one Ticket: When splitting work into multiple PRs, clearly describe what this PR addresses and outline the remaining work to complete the ticket.
  • Ensure Tests Are Included: Add or update unit, integration, or end-to-end tests to cover the changes made.
  • Follow Coding Standards: Ensure the code adheres to the team's coding guidelines and best practices.
  • Resolve Comments Promptly: If you raise a comment, ensure you follow up and resolve it before approving the PR to maintain clarity and ensure comments are addressed.
  • Foster Learning: PR reviews are an opportunity to share knowledge, provide constructive feedback, and encourage a collaborative environment.

🏷️ Naming Conventions Reminder

Please ensure the following naming conventions are followed:

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>

Copilot AI lite review requested due to automatic review settings August 19, 2026 12:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the OpenAPI specification to accept the HTTPS variant of the HL7 v3-RoleCode CodeSystem URI for relationship coding, and adjusts the documented default for that field.

Changes:

  • Added https://terminology.hl7.org/CodeSystem/v3-RoleCode to relevant enum lists for relationship system fields.
  • Changed the default relationship system value from the HTTP URI to the HTTPS URI.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread specification/validated-relationships-service-api.yaml Outdated
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants