refactor(crypto): preserve Ed25519 wire format with dalek - #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves authentication signing from the unmaintained signing wrapper to
ed25519-dalek3.0 while preserving both deployed layouts: 64-byteseed || public keykeypairs andsignature || messagesigned payloads.The compatibility boundary is executable: RFC 8032 vector 1 must produce the exact signature bytes, persisted keypairs with mismatched public halves are rejected, and modified signatures fail verification. The root server no longer declares
sodiumoxide; the vendored common library still uses it only for the separatebox_and XSalsa20-Poly1305secretboxprotocol operations.Validation:
cargo test --locked --all-targets: 7 + 5 + 1 tests passedcargo test --locked --manifest-path libs/hbb_common/Cargo.toml crypto_sign: 2 passedcargo clippy --locked --all-targets -- -D warningscargo fmt --all --checkgit diff --check