Skip to content

build(ci): let git-ref dependency updates reach main - #13

Merged
rldyourmnd merged 2 commits into
mainfrom
build/commitlint-allows-unwrappable-lines
Sep 2, 2026
Merged

build(ci): let git-ref dependency updates reach main#13
rldyourmnd merged 2 commits into
mainfrom
build/commitlint-allows-unwrappable-lines

Conversation

@rldyourmnd

Copy link
Copy Markdown
Contributor

The stock body-max-line-length allows 100 characters, and Dependabot writes a 144-character compare link into the body of every bump of a dependency pinned by git ref. A URL has no wrap point, so the rule is unsatisfiable for that commit and the update never lands. Five dependencies here are pinned that way, so this is latent rather than hypothetical — it is what blocked three pull requests in the client repository on 2026-09-02.

The limit is kept and measured over what could have been wrapped: a line is exempt only when one of its own tokens is longer than the limit. Verified against commitlint 19 with four controls — the Dependabot body passes, a 119-character line of ordinary words fails, an ordinary commit passes, a commit with no type fails.

Same file as NDDev-OpenNetwork/nremote, which merged it in #28.

https://claude.ai/code/session_01WFnbbqyGJC9DJVoF3JhfvW

The stock `body-max-line-length` allows 100 characters. Dependabot writes a
144-character compare link into the body of every bump of a dependency pinned
by git ref, and there is no wrap point inside a URL, so the rule is
unsatisfiable for that commit and the update never lands. Five dependencies
here are pinned that way.

The limit is kept and measured over what could have been wrapped: a line is
exempt only when one of its own whitespace-separated tokens is longer than the
limit. A 120-character line of ordinary words still fails. Verified against
commitlint 19 with both controls before this was written; the same file is
already merged in the client repository, where it unblocked three pull
requests.

Claude-Session: https://claude.ai/code/session_01WFnbbqyGJC9DJVoF3JhfvW
@rldyourmnd
rldyourmnd enabled auto-merge September 2, 2026 15:27
The version first written here exempted a line carrying one token longer than
the limit. That covers the compare link and nothing else. A grouped update
also writes markdown table rows at 102 characters whose longest token is 79,
and sentences that carry a link at 121 - both of which the narrow rule still
rejected, which is how the client repository stayed blocked after the fix that
was supposed to unblock it.

The predicate is now the one the comment always claimed: the limit is measured
over what the author could have wrapped, with each URL counted as one
character. `scripts/check_commitlint_config.mjs` holds seven controls, four
that must be exempt and three that must not, and the new `contracts` job runs
it.

Claude-Session: https://claude.ai/code/session_01WFnbbqyGJC9DJVoF3JhfvW
@rldyourmnd
rldyourmnd merged commit f741a13 into main Sep 2, 2026
26 checks passed
@rldyourmnd
rldyourmnd deleted the build/commitlint-allows-unwrappable-lines branch September 2, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant