fix(alerts): keep diagnostic emptiness a vector - #383
Merged
Conversation
OpenObserve v1 correctly rejects the sustained diagnostic expression when an empty max-by aggregation becomes a scalar before its range subquery. The metric already has exactly one host-labelled series, so preserve that vector and assert the rendered rule shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenObserve v1 exposed a latent rule-shape defect: in an empty window,
max by (...)produced a scalar before the sustained range subquery, and the engine correctly rejected it with error 20008 (expected matrix, got scalar). The diagnostic exporter already emits one host-labelled series, so the aggregation was redundant.Keep the source vector intact and assert the exact rendered sustained expression.
Verification:
go test ./internal/observabilityrulesmake verifydiagnostic_export_failurenow haslast_outcome=normal,level=ok,groups_firing=0