feat(actionlint): tool_source picks the baked surface over a download - #81
Merged
Conversation
Fleet images bake actionlint and shellcheck, yet every fleet job paid the download anyway. tool_source picks the source: download stays the pinned checksum-verified tarball, image requires the runner's baked tool and reports its version and digest (the image build chain is the trust root), and auto uses the baked surface exactly when the nddev image marker and the tool are both present -- hosted runners keep downloading, byte for byte as before. The baked shellcheck is the image's apt surface and can trail the download pin, so the image path says so where the verdict sits. Claude-Session: https://claude.ai/code/session_01LsGid6U5RrQdFvJmvYdGCF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
tool_sourceinput (auto/image/download, defaultauto) to the actionlint workflow, covering the shellcheck lane too.download: today's behavior, pinned + checksum-verified, unchanged byte for byte.image: requires the baked tool, reports version + sha256; the image build chain (manifest binary_sha256 + estate audit) is the trust root.auto: baked only when/etc/nddev/image-build.jsonexists and the tool is present — hosted runners keep the verified download.The baked shellcheck is the image's apt surface (0.9.0 today vs the 0.11.0 download pin); the image step reports the version in the same log as the verdict, and strict consumers select
tool_source: download.validate_all --tier core: OK (48 groups), incl. the actionlint runner-contract and suppression-scope validators.
Closes the estate ledger item
ci-workflows-uses-baked-tools.https://claude.ai/code/session_01LsGid6U5RrQdFvJmvYdGCF