fix(security): upload evidence only when the scan ran - #78
Merged
Conversation
A job that died in its own bootstrap ended by reporting ##[error]Path does not exist: .../_temp/private-security-zizmor.sarif which is a true statement about a file and a false statement about the run. The real failure was three steps earlier, in `Fetch exact called-workflow implementation`, and the message that reached the reviewer named the wrong thing entirely. Two people reported the missing SARIF as the defect; both were reading the last error rather than the first. The evidence uploads were `always()`, so they ran after a bootstrap that produced no scanners and no output. They are now guarded on the scan step having run at all. Evidence is still uploaded when the scan runs and finds problems, which is the case `always()` existed for. private-security-bundle-free.yml carried the same guard and had no id on its scan step; it has one now, so the condition resolves there too. This is the reporting half of #76, which fixed the cause. Together the bootstrap stops failing one run in five, and when anything else fails the job names the step that failed.
rldyourmnd
force-pushed
the
fix/upload-evidence-only-when-the-scan-ran
branch
from
August 31, 2026 10:54
15e3362 to
bdbcf13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A job that died in its own bootstrap ended by reporting this:
That is a true statement about a file and a false statement about the run. The real failure was three steps earlier —
Fetch exact called-workflow implementation— and the message that reached the reviewer named the wrong thing entirely. Two people independently reported the missing SARIF as the defect; both were reading the last error rather than the first.The evidence uploads were
if: always(), so they ran after a bootstrap that had produced no scanners and no output. They are now guarded on the scan step having run at all:Evidence is still uploaded when the scan runs and finds problems, which is the case
always()existed for.private-security-bundle-free.ymlcarried the same guard and had noidon its scan step; it has one now, so the condition resolves there too.This is the reporting half of #76, which fixed the cause. Together: the bootstrap stops failing one run in five, and when anything else fails the job names the step that failed.