Skip to content

Point the runbook at NCode Review's runbook - #476

Merged
polewskm merged 3 commits into
mainfrom
worktree-issue-472
Nov 21, 2026
Merged

polewskm merged 3 commits into
mainfrom
worktree-issue-472

Conversation

@polewskm

Copy link
Copy Markdown
Collaborator

docs/adopt.md's NCode Review steps (0.3, section 5's introduction and 5.1) now link NCode Review's own runbook, Set Up NCode Review, End to End, at its once-per-organization, once-per-repository and troubleshooting sections. They no longer point at code-review's README sections "Using it" and "Opting a repository in", or at NCodeGroup/code-review#237, so NCode Review's setup has one procedure.
The links use the runbook on main, because no NCode Review release tag holds it yet.
The plan's follow-up is fixed here too: USAGE.md's NCode Review paragraph sends an existing project to Update-Project.ps1 -Data @{ code_review = $true }, docs/adopt.md section 5 and the runbook. It also names the NCode Review Approver and Enable-CodeReview.ps1 -ApproverPrivateKeyPath, which it used to leave out.
Both changes are logged under ## [Unreleased]. Nothing a release ships changes, so there's no release.

Protected paths changed:
none

Closes #472

@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Light review (documentation only): No findings.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
hygiene haiku-5-5 0 🟢

Skipped: api-compat, architecture, completeness, conventions, correctness, data-model, infrastructure, intent, performance, security, tests

Trial: findings are posted as review threads and in the check run. $0.00 on Amazon Bedrock, 15s, at eea7975. (how to interact)

📋 Outcomes

Merged at eea7975. No findings were posted as threads.

@polewskm

Copy link
Copy Markdown
Collaborator Author

Autopilot: this pull request is ready to merge as far as this run can tell.

  • NCode Review reviewed the head it opened with, eea7975, and approved it with no findings (light review, documentation only). No review threads were opened, and no maintainer comment asks for a change.
  • No rounds of review feedback were needed, and every check on eea7975 passes, test included.
  • The plan's one follow-up, bringing USAGE.md's NCode Review paragraph up to date, is fixed here in step 3 (eea7975), so nothing is left as a follow-up or for the maintainer.
  • Protected paths changed: none. The pull request changes only docs/adopt.md, USAGE.md and CHANGELOG.md.
  • No threads are unresolved.

It has no Release: line: it changes nothing a release ships, so its entries sit under ## [Unreleased]. Merge it with a merge commit or by rebasing, not by squashing. Then run /finish-plan issue-472.

@polewskm polewskm self-assigned this Nov 21, 2026
@polewskm
polewskm marked this pull request as ready for review November 21, 2026 23:01
@polewskm
polewskm deployed to code-review November 21, 2026 23:01 — with GitHub Actions Active
@polewskm
polewskm merged commit d90fb36 into main Nov 21, 2026
71 checks passed
@polewskm
polewskm deleted the worktree-issue-472 branch November 21, 2026 23:01

This branch was successfully deployed

1 active deployment
code-review — eea79755 Deployed Nov 21, 2026 by polewskm via review #1299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Point the runbook at NCode Review's runbook

1 participant