Skip to content

docs: write Best Practices documents and pass NCode Review's approval inputs - #901

Merged
polewskm merged 15 commits into
mainfrom
worktree-issue-898
Nov 22, 2026
Merged

polewskm merged 15 commits into
mainfrom
worktree-issue-898

Conversation

@polewskm

@polewskm polewskm commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor

NCode Review pins v1.4.2, the newest release past the three-day cooldown, and passes approve: true and the NCode Review Approver's key, so a review that leaves no blocker or should-fix finding open approves the pull request; v1.5.0 and later submit that approval as the Approver, which can meet a required approval.
docs/assurance-case.md, docs/architecture.md and ROADMAP.md describe this family: its twelve security requirements, threat model, design principles, the weaknesses it counters, evidence, components, design rules and direction, each claim citing the decision record that decides it.
.vscode/settings.json is project-owned through the project_owned_files answer, and AGENTS.md and the changelog catalog say so.
#898 and #899 stay open for the work outside the repository's files: the v1.5.0 pin once past its cooldown, the approver's key and the main ruleset's required approval (#898), and /best-practices with the bestpractices.dev registration (#899).

Protected paths changed:
.copier-answers.yml
.github/workflows/code-review.yml
AGENTS.md

Closes #900
Partly completes #898
Partly completes #899

@polewskm
polewskm deployed to code-review November 22, 2026 01:59 — with GitHub Actions Active

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 3a30be1: 3 new findings on the changed lines.

Comment thread .github/workflows/code-review.yml Resolved
Comment thread .github/workflows/code-review.yml Resolved
Comment thread docs/architecture.md Resolved
@ncode-review

ncode-review Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Superseded by the review at eae0431.

@polewskm

Copy link
Copy Markdown
Contributor Author

/review

@polewskm polewskm changed the title docs: write Best Practices documents and adopt NCode Review's approval docs: write Best Practices documents and pass NCode Review's approval inputs Nov 22, 2026
@ncode-review

ncode-review Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at 3a30be1: 2 hunks in 2 files and changes taken back in 2 files, by correctness only. Earlier findings: F1 fixed, F2 fixed, F3 fixed. No further findings above nits.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.06 on Amazon Bedrock, 11s, at eae0431. (how to interact)

📋 Outcomes

Merged at eae0431: 2 fixed, 1 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 intent, rule-check 🟠 Should fix 👎 dismissed
F2 conventions, rule-check 🟡 Nit ✅ fixed
F3 rule-check 🟡 Nit ✅ fixed

@polewskm polewskm self-assigned this Nov 22, 2026
@polewskm
polewskm marked this pull request as ready for review November 22, 2026 02:18
@polewskm
polewskm deployed to code-review November 22, 2026 02:18 — with GitHub Actions Active
@polewskm
polewskm enabled auto-merge November 22, 2026 02:19
@polewskm

Copy link
Copy Markdown
Contributor Author

Autopilot: this pull request is ready to merge as far as this run can tell.

  • One round of review feedback: NCode Review's three findings on 3a30be1 (F1 should-fix, F2 and F3 nits) all held and are fixed. F1 is fixed by closing Make .vscode/settings.json project-owned #900 alone and naming Adopt NCode Review's approval #898 and Write the OpenSSF Best Practices documents #899 as partly completed, F2 in 7011cde and F3 in 0902c59. Its re-review of eae0431 gives Approve with no further findings.
  • No finding is left as a follow-up or for you, and no review thread is unresolved.
  • The work outside the repository's files stays in Adopt NCode Review's approval #898 and Write the OpenSSF Best Practices documents #899, which this pull request leaves open: the v1.5.0 pin once past its cooldown (2026-11-24T16:36Z), the NCode Review Approver's key and the main ruleset's required approval, and /best-practices with the bestpractices.dev registration. Once this merges, /ship-plan issue-898 comments on both and rewrites their bodies to describe only what remains, then /finish-plan issue-898 retires the plan.
  • Protected paths this pull request changes: .copier-answers.yml, .github/workflows/code-review.yml, AGENTS.md.
  • The local gate ./build/dod.ps1 -Fast -Affected passed on eae0431. CI passes except Analyze (csharp), which is still running.

@polewskm
polewskm added this pull request to the merge queue Nov 22, 2026
Merged via the queue into main with commit e0fd370 Nov 22, 2026
17 checks passed
@polewskm
polewskm deleted the worktree-issue-898 branch November 22, 2026 02:36

This branch was successfully deployed

1 active deployment
code-review — eae04312 Deployed Nov 22, 2026 by polewskm via review #2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make .vscode/settings.json project-owned

1 participant