Repository navigation
Update to project-template v0.111.1 - #238
Conversation
There was a problem hiding this comment.
🤖 NCode Review at 04fa487: 2 new findings on the changed lines.
There was a problem hiding this comment.
Approved at 04fa487: no blocker or should-fix finding remains.
|
Superseded by the review at 783c788. |
|
/review |
There was a problem hiding this comment.
Approved at 783c788: no blocker or should-fix finding remains.
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at 04fa487: 1 hunk in 1 file and changes taken back in 1 file, by correctness only. Earlier findings: F1 fixed, F2 answered. No further findings above nits. Approval: Approved — no blocker or should-fix finding remains. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.03 on Amazon Bedrock, 15s, at 783c788. (how to interact) 📋 OutcomesMerged at 783c788: 1 fixed, 1 dismissed, 0 acknowledged, 0 ignored.
|
Moves the project from project-template v0.106.0 to v0.111.1 with
Update-Project.ps1 -Ref v0.111.1. This brings in/run-issues-all-in, the refreshed workflow commands and/best-practices, the file-header check fix, the newcode-review-auto-merge.ymlcomment, and the template's ADR-0033 to ADR-0036 and ADR-0153.For the project-owned files the template changed:
GOVERNANCE.mdtakes the template's Automation row.AGENTS.md'sdraftkey cites ADR-0036 and ADR-1011: here the NCode Review Approver's approval meets the required approval.CONTRIBUTING.mdandcode-review.ymlkeep their own text. The template's new wording says the opposite of how approvals work in this repository; AGENTS.md and CONTRIBUTING.md say NCode Review's approval meets no required approval, which ADR-0036 amends project-template#466 tracks that.There is no release: nothing the action ships changes, so the changelog entry waits under
[Unreleased].