Repository navigation
Warn and go on when GitHub refuses to list an app installation's repositories - #236
Conversation
There was a problem hiding this comment.
🤖 NCode Review at 98fb7d8: 3 new findings on the changed lines.
|
Superseded by the review at 3a5ca98. |
…or otherwise, and say why gh is called directly
|
/review Generated by Claude Code |
There was a problem hiding this comment.
Approved at 3a5ca98: no blocker or should-fix finding remains.
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at 98fb7d8: 3 hunks in 3 files and changes taken back in 3 files, by correctness only. No further findings above nits. Approval: Approved — no blocker or should-fix finding remains. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.01 on Amazon Bedrock, 10s, at 3a5ca98. (how to interact) 📋 OutcomesMerged at 3a5ca98: 3 fixed, 0 dismissed, 0 acknowledged, 0 ignored.
|
For an app installed on selected repositories only,
tools/Enable-CodeReview.ps1lists the installation's repositories (user/installations/<id>/repositories) to add the repository when it's missing. GitHub serves that list only to a GitHub App's user token or a personal access token, never to the OAuth tokengh auth logingives, so every run with the NCode Review Approver failed there before it changed anything. No scope fixes it.Add-ToInstallationdoes that check for both apps. When GitHub refuses the list, it warns, names the installation's settings page where the repository is selected by hand, and the run goes on to set up the environment and its secrets.PUTto the installation, and that the environment secret is still set.[Unreleased]entry. The script runs from a clone, so the change releases nothing.The gate passes: 1067 tests, 93.6% branch coverage.
Generated by Claude Code