Skip to content

Warn and go on when GitHub refuses to list an app installation's repositories - #236

Merged
polewskm merged 2 commits into
mainfrom
claude/charming-cray-q7vja4
Nov 21, 2026
Merged

polewskm merged 2 commits into
mainfrom
claude/charming-cray-q7vja4

Conversation

@polewskm

Copy link
Copy Markdown
Contributor

For an app installed on selected repositories only, tools/Enable-CodeReview.ps1 lists the installation's repositories (user/installations/<id>/repositories) to add the repository when it's missing. GitHub serves that list only to a GitHub App's user token or a personal access token, never to the OAuth token gh auth login gives, so every run with the NCode Review Approver failed there before it changed anything. No scope fixes it.

  • Add-ToInstallation does that check for both apps. When GitHub refuses the list, it warns, names the installation's settings page where the repository is selected by hand, and the run goes on to set up the environment and its secrets.
  • A test runs a refused list and checks for the warning, for no PUT to the installation, and that the environment secret is still set.
  • The script's help says so, and the changelog has an [Unreleased] entry. The script runs from a clone, so the change releases nothing.

The gate passes: 1067 tests, 93.6% branch coverage.


Generated by Claude Code

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 98fb7d8: 3 new findings on the changed lines.

Comment thread tools/Enable-CodeReview.ps1 Resolved
Comment thread tools/Enable-CodeReview.ps1 Resolved
Comment thread tools/Enable-CodeReview.ps1 Resolved
@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Superseded by the review at 3a5ca98.

…or otherwise, and say why gh is called directly

Copy link
Copy Markdown
Contributor Author

/review


Generated by Claude Code

@polewskm
polewskm marked this pull request as ready for review November 21, 2026 17:18
@polewskm polewskm self-assigned this Nov 21, 2026

@ncode-review-approver ncode-review-approver Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 3a5ca98: no blocker or should-fix finding remains.

@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at 98fb7d8: 3 hunks in 3 files and changes taken back in 3 files, by correctness only. No further findings above nits.

Approval: Approved — no blocker or should-fix finding remains.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.01 on Amazon Bedrock, 10s, at 3a5ca98. (how to interact)

📋 Outcomes

Merged at 3a5ca98: 3 fixed, 0 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 hygiene, correctness, rule-check 🟠 Should fix ✅ fixed
F2 hygiene 🟡 Nit ✅ fixed
F3 rule-check 🟡 Nit ✅ fixed

@polewskm
polewskm merged commit 2ba16c4 into main Nov 21, 2026
8 checks passed
@polewskm
polewskm deleted the claude/charming-cray-q7vja4 branch November 21, 2026 17:19

This branch was previously deployed

1 inactive deployment
code-review — 3a5ca98b Deployed Nov 21, 2026 by polewskm via review #802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant