Repository navigation
Pin this repository's review to v1.5.0 and pass the approver's key - #235
Conversation
There was a problem hiding this comment.
🤖 NCode Review at 269a49c: 1 new finding on the changed lines.
|
Superseded by the review at 02d67ce. |
|
/review Generated by Claude Code |
There was a problem hiding this comment.
Approved at 02d67ce: no blocker or should-fix finding remains.
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at 269a49c: 3 hunks in 1 file and changes taken back in 1 file, by correctness only. Earlier findings: F1 fixed. No further findings above nits. Approval: Approved — no blocker or should-fix finding remains. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.03 on Amazon Bedrock, 10s, at 02d67ce. (how to interact) 📋 OutcomesMerged at 02d67ce: 1 fixed, 0 dismissed, 0 acknowledged, 0 ignored.
|
This repository's own
.github/workflows/code-review.ymlpins NCode Review v1.5.0 (a4cdf65) in both jobs. The review job passesapprover-private-key: ${{ secrets.NCODE_REVIEW_APPROVER_PRIVATE_KEY }}, so once the key is in thecode-reviewenvironment, the NCode Review Approver submits the approval of a clean review and it meets the ruleset's required approval. Until then the secret is empty and NCode Review approves as its own app, as before. The header comment describes the approver, and the changelog has an[Unreleased]entry. It changes only CI, so it releases nothing.The gate passes.
Before the approval can count: run
tools/Enable-CodeReview.ps1 -Repo code-review,Buffers,PropertyBag -ApproverPrivateKeyPath <the approver's .pem>, then put back the required approval with the project template'stools/Set-RepositoryBaseline.ps1 -Repo code-reviewfrom v0.111.0 (NCodeGroup/project-template#462).Closes #234
Generated by Claude Code