Skip to content

Pin this repository's review to v1.5.0 and pass the approver's key - #235

Merged
polewskm merged 2 commits into
mainfrom
claude/charming-cray-q7vja4
Nov 21, 2026
Merged

polewskm merged 2 commits into
mainfrom
claude/charming-cray-q7vja4

Conversation

@polewskm

Copy link
Copy Markdown
Contributor

This repository's own .github/workflows/code-review.yml pins NCode Review v1.5.0 (a4cdf65) in both jobs. The review job passes approver-private-key: ${{ secrets.NCODE_REVIEW_APPROVER_PRIVATE_KEY }}, so once the key is in the code-review environment, the NCode Review Approver submits the approval of a clean review and it meets the ruleset's required approval. Until then the secret is empty and NCode Review approves as its own app, as before. The header comment describes the approver, and the changelog has an [Unreleased] entry. It changes only CI, so it releases nothing.

The gate passes.

Before the approval can count: run tools/Enable-CodeReview.ps1 -Repo code-review,Buffers,PropertyBag -ApproverPrivateKeyPath <the approver's .pem>, then put back the required approval with the project template's tools/Set-RepositoryBaseline.ps1 -Repo code-review from v0.111.0 (NCodeGroup/project-template#462).

Closes #234


Generated by Claude Code

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 269a49c: 1 new finding on the changed lines.

Comment thread .github/workflows/code-review.yml Resolved
@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Superseded by the review at 02d67ce.

Copy link
Copy Markdown
Contributor Author

/review


Generated by Claude Code

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 02d67ce: no blocker or should-fix finding remains.

@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at 269a49c: 3 hunks in 1 file and changes taken back in 1 file, by correctness only. Earlier findings: F1 fixed. No further findings above nits.

Approval: Approved — no blocker or should-fix finding remains.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.03 on Amazon Bedrock, 10s, at 02d67ce. (how to interact)

📋 Outcomes

Merged at 02d67ce: 1 fixed, 0 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 hygiene, conventions, rule-check 🟠 Should fix ✅ fixed

@polewskm polewskm self-assigned this Nov 21, 2026
@polewskm
polewskm marked this pull request as ready for review November 21, 2026 17:08
@polewskm
polewskm merged commit 873fc7a into main Nov 21, 2026
7 checks passed
@polewskm
polewskm deleted the claude/charming-cray-q7vja4 branch November 21, 2026 17:08

This branch was previously deployed

1 inactive deployment
code-review — 02d67ce8 Deployed Nov 21, 2026 by polewskm via review #797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass the approver's key in this repository's own review

1 participant