Skip to content

Approve as a dedicated approver app - #233

Merged
polewskm merged 8 commits into
mainfrom
claude/charming-cray-q7vja4
Nov 21, 2026
Merged

polewskm merged 8 commits into
mainfrom
claude/charming-cray-q7vja4

Conversation

@polewskm

Copy link
Copy Markdown
Contributor

With approve: true and the new approver-private-key input, NCode Review submits its approval as the NCode Review Approver (ncode-review-approver), an app installed with Contents: write on the repositories that approve. GitHub counts an approval toward a ruleset's required approval only from a reviewer that can write, which NCodeGroup/project-template#460 tested. The approver's token is minted after the agents exit, for this repository only, with Pull requests: write alone, so it can't push.

  • action.yml: approver-private-key and approver-client-id (default Iv23liDPFX1K6NjGIr9i), a Get the approver's token step, and the publish step's env. A test checks that the key reaches only that step and the token only the publish step.
  • src/comments.ts, src/publish.ts: the approval and its dismissal go through the approver, which also dismisses the NCode Review app's own approvals. Without the key, behavior is unchanged; with the key but no token, the run warns and approves as NCode Review.
  • tools/Enable-CodeReview.ps1 -ApproverPrivateKeyPath: stores the key as a secret of each repository's code-review environment, never as an organization secret, and adds the repository to the approver's installation.
  • README Approvals section, ADR-1011 (amends ADR-1009), and the v1.5.0 changelog section.

The gate passes: file headers, typecheck, lint, 1061 tests, 93.2% statement and 93.4% branch coverage.

After merge: run tools/Enable-CodeReview.ps1 -Repo Buffers,PropertyBag,code-review -ApproverPrivateKeyPath <the approver's .pem>, then pass approver-private-key: ${{ secrets.NCODE_REVIEW_APPROVER_PRIVATE_KEY }} in each review once it pins v1.5.0.

Release: v1.5.0

Closes #232
Refs NCodeGroup/project-template#460


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

/review


Generated by Claude Code

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at e8d7105: 4 new findings on the changed lines.

Comment thread src/publish.ts Resolved
Comment thread tools/Enable-CodeReview.ps1 Resolved
Comment thread tools/Enable-CodeReview.ps1 Resolved
Comment thread tools/Enable-CodeReview.ps1 Resolved
@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Superseded by the review at 7a9b92f.

…stallations once, and check an empty or non-PEM approver key

Copy link
Copy Markdown
Contributor Author

/review


Generated by Claude Code

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 7a9b92f: no blocker or should-fix finding remains.

@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at e8d7105: 10 hunks in 5 files and changes taken back in 2 files, by correctness only. Earlier findings: F1 fixed, F2 fixed, F3 fixed, F4 fixed. No further findings above nits.

Approval: Approved — no blocker or should-fix finding remains.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.05 on Amazon Bedrock, 9s, at 7a9b92f. (how to interact)

📋 Outcomes

Merged at 7a9b92f: 3 fixed, 1 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 tests, rule-check 🟠 Should fix ✅ fixed
F2 conventions, rule-check 🟡 Nit ✅ fixed
F3 tests, rule-check 🟡 Nit 👎 dismissed
F4 rule-check 🟡 Nit ✅ fixed

@polewskm
polewskm marked this pull request as ready for review November 21, 2026 16:27
@polewskm
polewskm merged commit a4cdf65 into main Nov 21, 2026
8 checks passed
@polewskm
polewskm deleted the claude/charming-cray-q7vja4 branch November 21, 2026 16:34

This branch was previously deployed

1 inactive deployment
code-review — 7a9b92f3 Deployed Nov 21, 2026 by polewskm via review #790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Submit the approval as a dedicated approver app, so it meets a ruleset's required approval

1 participant