Repository navigation
Approve as a dedicated approver app - #233
Conversation
… nothing shaped like a private key
|
/review Generated by Claude Code |
There was a problem hiding this comment.
🤖 NCode Review at e8d7105: 4 new findings on the changed lines.
|
Superseded by the review at 7a9b92f. |
…stallations once, and check an empty or non-PEM approver key
|
/review Generated by Claude Code |
There was a problem hiding this comment.
Approved at 7a9b92f: no blocker or should-fix finding remains.
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at e8d7105: 10 hunks in 5 files and changes taken back in 2 files, by correctness only. Earlier findings: F1 fixed, F2 fixed, F3 fixed, F4 fixed. No further findings above nits. Approval: Approved — no blocker or should-fix finding remains. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.05 on Amazon Bedrock, 9s, at 7a9b92f. (how to interact) 📋 OutcomesMerged at 7a9b92f: 3 fixed, 1 dismissed, 0 acknowledged, 0 ignored.
|
With
approve: trueand the newapprover-private-keyinput, NCode Review submits its approval as the NCode Review Approver (ncode-review-approver), an app installed with Contents: write on the repositories that approve. GitHub counts an approval toward a ruleset's required approval only from a reviewer that can write, which NCodeGroup/project-template#460 tested. The approver's token is minted after the agents exit, for this repository only, with Pull requests: write alone, so it can't push.action.yml:approver-private-keyandapprover-client-id(defaultIv23liDPFX1K6NjGIr9i), aGet the approver's tokenstep, and the publish step's env. A test checks that the key reaches only that step and the token only the publish step.src/comments.ts,src/publish.ts: the approval and its dismissal go through the approver, which also dismisses the NCode Review app's own approvals. Without the key, behavior is unchanged; with the key but no token, the run warns and approves as NCode Review.tools/Enable-CodeReview.ps1 -ApproverPrivateKeyPath: stores the key as a secret of each repository'scode-reviewenvironment, never as an organization secret, and adds the repository to the approver's installation.The gate passes: file headers, typecheck, lint, 1061 tests, 93.2% statement and 93.4% branch coverage.
After merge: run
tools/Enable-CodeReview.ps1 -Repo Buffers,PropertyBag,code-review -ApproverPrivateKeyPath <the approver's .pem>, then passapprover-private-key: ${{ secrets.NCODE_REVIEW_APPROVER_PRIVATE_KEY }}in each review once it pins v1.5.0.Release: v1.5.0
Closes #232
Refs NCodeGroup/project-template#460
Generated by Claude Code