Skip to content

Update from project-template v0.75.1 - #179

Merged
polewskm merged 6 commits into
mainfrom
worktree-template-update-v0.75.0
Nov 9, 2026
Merged

polewskm merged 6 commits into
mainfrom
worktree-template-update-v0.75.0

Conversation

@polewskm

@polewskm polewskm commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Brings the repository from project-template v0.68.4 to v0.75.1: the template's workflow commands and instructions, allow-all Claude Code permissions with a pwsh SessionStart hook, the nvs scripts and ADR-0200, and tag-release.yml, which publishes nothing here because release stays none.

  • The one update conflict, in ci.yml, is resolved by keeping the project's npm ci --ignore-scripts --no-audit --no-fund line, so ci.yml and .node-version (24) are unchanged.
  • The prelude stays tools/Use-Node.ps1: the template's .template/Use-Node.ps1 throws where nvs isn't installed, as on CI and in cloud sessions (NCodeGroup/project-template#307). ADR-1002 records it.
  • The manual release.yml workflow is named Release (manual), so it isn't confused with the template's Release workflow (#309). AGENTS.md, CONTRIBUTING.md, README.md and CHANGELOG.md describe all of it.

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 29795b8: 1 new finding on the changed lines.

Comment thread .claude/settings.json Resolved
@ncode-review

ncode-review Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Superseded by the review at 2e999ce.

@polewskm
polewskm marked this pull request as ready for review November 9, 2026 03:01
@polewskm
polewskm enabled auto-merge November 9, 2026 03:01
@ncode-review

ncode-review Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at 29795b8: 2 hunks in 2 files and changes taken back in 2 files, by correctness only. No further findings above nits.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.03 on Claude API, 8s, at 2e999ce. (how to interact)

📋 Outcomes

Merged at 2e999ce: 1 fixed, 0 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 security, rule-check 🟠 Should fix ✅ fixed

@polewskm
polewskm merged commit 060f721 into main Nov 9, 2026
10 checks passed
@polewskm
polewskm deleted the worktree-template-update-v0.75.0 branch November 9, 2026 03:04

This branch was previously deployed

1 inactive deployment
code-review — 2e999cea Deployed Nov 9, 2026 by polewskm via review #610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant