Skip to content

Update from project-template v0.68.4 - #178

Merged
polewskm merged 8 commits into
mainfrom
claude/trusting-cannon-02y0ac
Nov 8, 2026
Merged

polewskm merged 8 commits into
mainfrom
claude/trusting-cannon-02y0ac

Conversation

@polewskm

@polewskm polewskm commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Moves the repository from project-template v0.61.2 to v0.68.4: Copilot copies of /address-feedback and /run-feedback, resuming a stopped feedback run in either tool, /run-issues and /run-feedback leaving their /review comment as posted, ADR-0015 (pre-release posture), and an Update-Project.ps1 that stages only what an update changes.

  • Step 1 runs .template/Update-Project.ps1 -Ref v0.68.4 -NoCommit (74 template-owned files, no conflicts).
  • The project's own files are updated by hand: AGENTS.md names the feedback commands and sets pre-release: tracked (the project has released v1.x), tools/Use-Node.ps1 help, the comments in code-review.yml (its concurrency group is unchanged), the docs/decisions/README.md index note, and the CHANGELOG.md entry.
  • CONTRIBUTING.md and README.md take none of the template's suggested hunks; their pre-release wording is for a project that hasn't released.
  • The template's update script suggests pre-release: untracked for a project with no such line: NCodeGroup/project-template#281.

npm run typecheck and npm test pass on Node 24 (944 of 945 tests, 1 skipped).

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 8713593: 1 new finding on the changed lines.

Comment thread CHANGELOG.md Resolved
@ncode-review

ncode-review Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Superseded by the review at 7995ae9.

@polewskm
polewskm force-pushed the claude/trusting-cannon-02y0ac branch from 8713593 to 7995ae9 Compare November 8, 2026 19:34
@polewskm
polewskm marked this pull request as ready for review November 8, 2026 19:36
@polewskm
polewskm enabled auto-merge November 8, 2026 19:36
@ncode-review

ncode-review Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Nothing in this pull request's own changes differs from the last review at 8713593, so nothing was reviewed again. No further findings above nits.

0 reviewers run — 0 findings (run details)

Reviewer Model Findings Top

Trial: findings are posted as review threads and in the check run. $0.00 on Amazon Bedrock, 7s, at 7995ae9. (how to interact)

📋 Outcomes

Merged at 7995ae9: 0 fixed, 1 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 hygiene, intent 🟡 Nit 👎 dismissed

@polewskm
polewskm merged commit d70a97b into main Nov 8, 2026
10 checks passed
@polewskm
polewskm deleted the claude/trusting-cannon-02y0ac branch November 8, 2026 19:38

This branch was previously deployed

1 inactive deployment
code-review — 7995ae9f Deployed Nov 8, 2026 by polewskm via review #605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant