Skip to content

Update from project-template v0.53.0 - #147

Merged
polewskm merged 7 commits into
mainfrom
worktree-template-update-v0.53.0
Nov 1, 2026
Merged

polewskm merged 7 commits into
mainfrom
worktree-template-update-v0.53.0

Conversation

@polewskm

@polewskm polewskm commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Moves the repository from project-template v0.41.1 to v0.53.0: the template's commands, agents and rules, the decision records in docs/decisions/project-template/, the new CONTRIBUTING.md, SECURITY.md and docs/, and the new workflows (template-update.yml, code-review-auto-merge.yml, copilot-setup-steps.yml).

  • ci.yml keeps the project's .node-version and npm ci --ignore-scripts, and takes the template's changes: the decision index check, with fetch-depth: 0 so it can compare with the default branch; the pull request title and description in the commit attribution check, which reruns on the new edited type when they change; a concurrency group that cancels a pull request's or topic branch's superseded run but never a default-branch or merge queue run; a 30-minute timeout; and pwsh as the test job's default shell, which changes no existing step.
  • src/template.ts lists audit-conventions among the template's generated commands, which test/template.test.ts requires after this update.
  • AGENTS.md takes the template's Landing paragraph and the review-bots, max-review-rounds and prelude keys at their defaults; draft: yes stays.
  • copilot-setup-steps.yml reads .node-version, as test/node-version.test.ts requires; the README links the new documents; CONTRIBUTING.md is fitted to this repository.
  • Template gap found on the way: Update-Project.ps1 -NoCommit leaves a merged .gitignore staged without the project's kept lines project-template#212 (Update-Project.ps1 -NoCommit stages a .gitignore without the project's kept lines).

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 598efd9: 7 new findings on the changed lines.

Comment thread .github/workflows/ci.yml Resolved
Comment thread .claude/commands/audit-conventions.md Resolved
Comment thread CHANGELOG.md Resolved
Comment thread .github/workflows/ci.yml Resolved
@ncode-review

ncode-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Superseded by the review at 598efd9.

@polewskm

polewskm commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

/review

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 598efd9: 1 new finding on the changed lines.
2 more were already posted on this pull request.

Comment thread .github/workflows/ci.yml Resolved
@ncode-review

ncode-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Superseded by the review at 598efd9.

@polewskm

polewskm commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

/review

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 598efd9: 3 new findings on the changed lines.
1 more was already posted on this pull request.

Comment thread CHANGELOG.md Resolved
Comment thread .copier-answers.yml Resolved
@ncode-review

ncode-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: 💬 Comment — This PR moves the repository from project-template v0.41.1 to v0.53.0. It brings in the template's commands, decision records, CONTRIBUTING/SECURITY docs and three new workflows, merges the template's CI changes into ci.yml, and adds audit-conventions to src/template.ts's generated-command list. Nearly all of it is template-owned content applied as the template ships it. The project-specific edits (ci.yml, AGENTS.md Landing keys, CONTRIBUTING.md, copilot-setup-steps.yml) are small, consistent with each other and well explained. The only open points are questions and minor gaps; none of them blocks the merge.

8 reviewers run — 4 findings (run details)

Reviewer Model Findings Top
synthesis opus-5-5 4 🟡
conventions sonnet-5-5 0 🟢
correctness sonnet-5-5 0 🟢
hygiene haiku-5-5 1 🟡
infrastructure haiku-5-5 0 🟢
intent haiku-5-5 2 🟠
rule-check sonnet-5-5 0 🟢
security sonnet-5-5 0 🟢
tests haiku-5-5 1 🟠

Skipped: api-compat, architecture, completeness, data-model, performance

Findings
  • 🟡 F1 .github/workflows/code-review-auto-merge.yml:70: Auto-merge eligibility logic has no test
  • 🟡 F2 .claude/commands/audit-conventions.md:1: Are the audit-conventions files recorded as template-owned?
  • 🟡 F3 CHANGELOG.md:14: Changed entry describes internal finding routing
  • 🟡 F4 .copier-answers.yml:6: Unexplained license: '' answer

Trial: findings are posted as review threads and in the check run. $2.46 on Amazon Bedrock, 120s, at 598efd9. (how to interact)

📋 Outcomes

Merged at 598efd9: 0 fixed, 11 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 conventions, rule-check 🟡 Nit 👎 dismissed
F2 tests 🟡 Nit 👎 dismissed
F3 intent 🟡 Nit 👎 dismissed
F4 intent 🟡 Nit 👎 dismissed
F5 hygiene 🟡 Nit 👎 dismissed
F6 hygiene 🟡 Nit 👎 dismissed
F7 intent 🟡 Nit 👎 dismissed
F2 intent 🟡 Nit 👎 dismissed
F1 tests 🟡 Nit 👎 dismissed
F3 hygiene 🟡 Nit 👎 dismissed
F4 intent 🟡 Nit 👎 dismissed

@polewskm
polewskm marked this pull request as ready for review November 1, 2026 23:43
@polewskm
polewskm merged commit 20376be into main Nov 1, 2026
13 checks passed
@polewskm
polewskm deleted the worktree-template-update-v0.53.0 branch November 1, 2026 23:44

This branch was previously deployed

1 inactive deployment
code-review — 598efd91 Deployed Nov 1, 2026 by polewskm via review #501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant