Skip to content

Pin the review workflow to code-review v0.3.1's commit SHA - #19

Merged
polewskm merged 2 commits into
mainfrom
ci/code-review-sha-pin
Oct 31, 2026
Merged

polewskm merged 2 commits into
mainfrom
ci/code-review-sha-pin

Conversation

@polewskm

Copy link
Copy Markdown
Contributor

Pins NCodeGroup/code-review to v0.3.1's full commit SHA, eaa9846049fdda1ce724fc34107391ba5f6d8708, with the tag in a comment, in place of the tag v0.3.0, and rewords the comment that explains the pin.

A tag pin, even an immutable release's, makes CodeQL's extended suite report the action as unpinned (actions/unpinned-tag) at every bump: NCodeGroup/identity-platform#26 tested v0.3.1, the first immutable release, and it was flagged the same way. A SHA is the one pin nobody can move, and Dependabot updates the SHA and the comment together. v0.3.1 has the same engine as v0.3.0.

@polewskm
polewskm deployed to code-review October 31, 2026 01:41 — with GitHub Actions Active

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 8c260e4: 1 new finding on the changed lines.

Not on a changed line:

  • 🟡 F2 Nit: Usage example still uses -Ref v0.3.0 .template/Update-Project.ps1:56. The script's usage example passes -Ref v0.3.0, while the workflow now pins v0.3.1. Fix: Is the example meant to show the current release? If so, change it to v0.3.1. If it's only illustrative, leave it.

Comment thread .github/workflows/code-review.yml Resolved
@ncode-review

ncode-review Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — No findings.

3 reviewers run — 0 findings (run details)

Reviewer Model Findings Top
conventions sonnet-5-5 0 🟢
hygiene haiku-5-5 0 🟢
rule-check sonnet-5-5 0 🟢

Skipped: api-compat, architecture, completeness, correctness, data-model, infrastructure, intent, performance, security, tests

Trial: findings are posted as review threads and in the check run. $0.12 on Amazon Bedrock, 23s, at de6aae0. (how to interact)

@polewskm

Copy link
Copy Markdown
Contributor Author

F2 (not on a changed line, .template/Update-Project.ps1:56): not changed. -Ref v0.3.0 there is a project-template version in the script's usage example, not this workflow's NCodeGroup/code-review release, so it doesn't follow v0.3.1. The script is generated by the template, which owns its examples.

@polewskm

Copy link
Copy Markdown
Contributor Author

/review

@polewskm
polewskm marked this pull request as ready for review October 31, 2026 01:51
@polewskm
polewskm deployed to code-review October 31, 2026 01:51 — with GitHub Actions Active
@polewskm
polewskm merged commit 2340fbc into main Oct 31, 2026
10 checks passed
@polewskm
polewskm deleted the ci/code-review-sha-pin branch October 31, 2026 01:52

This branch was successfully deployed

1 active deployment
code-review — de6aae0a Deployed Oct 31, 2026 by polewskm via review #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant