Repository navigation
Grant raise-baseline.yml the permissions it declares, so publishing starts - #127
Conversation
There was a problem hiding this comment.
🤖 NCode Review at aca7e43: 1 new finding on the changed lines.
Not on a changed line:
- 🟡 F2 Nit: Comment above the
baselinejob says it opens a draft pull request, which it no longer does.github/workflows/publish.yml:168. The comment says the job "Opens the draft pull request that raises the package validation baseline". In factraise-baseline.ymlpushesbaseline-<version>and opens an issue that links to the pull request, which a person then opens. Fix: Reword the comment: for a stable version, the job pushesbaseline-<version>and opens an issue that links to the pull request that raises the baseline.
There was a problem hiding this comment.
Approved at aca7e43: no blocker or should-fix finding remains.
|
Superseded by the review at aca7e43. |
|
Autopilot: Both nits hold. Neither is fixed here, because a push would dismiss the approval and delay the v5.5.0 publish.
Generated by Claude Code |
|
/review |
There was a problem hiding this comment.
🤖 NCode Review at aca7e43: 0 new findings on the changed lines.
1 more was already posted on this pull request.
Not on a changed line:
- 🟠 F1 Should fix: Comments still say the baseline job opens a pull request; raise-baseline.yml now opens an issue
.github/workflows/publish.yml:12. Two comments still describe the old behaviour: the file header at line 12 says raise-baseline.yml "opens the pull request that raises the package validation baseline", and the comment above thebaselinejob at line 168 says "Opens the draft pull request". raise-baseline.yml now pushesbaseline-<version>and opens an issue whose link a person uses to open the pull request. Fix: Reword both comments to say the job pushes the baseline branch and opens an issue that links to the pull request. At line 168, also say why onlycontents: writeandissues: writeare granted: the caller has to grant what the called workflow declares. - 🟡 F3 Nit: Header comment says baseline opens a pull request, but raise-baseline.yml now opens an issue
/home/runner/work/Buffers/Buffers/pr/.github/workflows/publish.yml:12. The file header describes raise-baseline.yml as the workflow that 'opens the pull request that raises the package validation baseline'. raise-baseline.yml (lines 1-5) pushes the branch and opens an issue whose link a person uses to open the pull request. This PR changes the baseline job's permissions to match that issue-based behavior but leaves this comment describing the old behavior. Fix: Reword the comment on lines 11-13 to say raise-baseline.yml pushes the baseline branch and opens an issue that links to the pull request.
Dismissed: the review at aca7e43 doesn't approve.
|
Superseded by the review at de8b1ee. |
|
Autopilot: Fixed in de8b1ee. Both comments in /review Generated by Claude Code |
|
/review Generated by Claude Code |
There was a problem hiding this comment.
Approved at de8b1ee: no blocker or should-fix finding remains.
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at aca7e43: 3 hunks in 2 files and changes taken back in 1 file, by correctness only. No further findings above nits. Approval: Approved — no blocker or should-fix finding remains. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.02 on Amazon Bedrock, 7s, at de8b1ee. (how to interact) 📋 OutcomesMerged at de8b1ee: 1 fixed, 0 dismissed, 0 acknowledged, 0 ignored.
|
The v5.5.0 publishing run (run) ended in
startup_failurewith no job, so v5.5.0 never reached nuget.org, which ends at 5.4.0. Since project-template v0.111.0 (#126),raise-baseline.ymlopens an issue and declarescontents: writeandissues: write.publish.yml'sbaselinejob still grantedactions: write,contents: writeandpull-requests: write, and GitHub refuses to start a run whose called workflow asks for more than its caller grants..github/workflows/publish.yml: thebaselinejob grantscontents: writeandissues: write, as project-template v0.111.1 does (Grant raise-baseline.yml the permissions it declares project-template#467).CHANGELOG.md: an[Unreleased]entry. It changes only CI, so it releases nothing.After merge, publish v5.5.0: Actions → Publish packages → Run workflow, on
main, with tagv5.5.0. The workflow checks out and packs the tag's commit, so the packages are v5.5.0's.Generated by Claude Code