Skip to content

Grant raise-baseline.yml the permissions it declares, so publishing starts - #127

Merged
polewskm merged 2 commits into
mainfrom
claude/charming-cray-q7vja4
Nov 21, 2026
Merged

polewskm merged 2 commits into
mainfrom
claude/charming-cray-q7vja4

Conversation

@polewskm

Copy link
Copy Markdown
Contributor

The v5.5.0 publishing run (run) ended in startup_failure with no job, so v5.5.0 never reached nuget.org, which ends at 5.4.0. Since project-template v0.111.0 (#126), raise-baseline.yml opens an issue and declares contents: write and issues: write. publish.yml's baseline job still granted actions: write, contents: write and pull-requests: write, and GitHub refuses to start a run whose called workflow asks for more than its caller grants.

After merge, publish v5.5.0: Actions → Publish packages → Run workflow, on main, with tag v5.5.0. The workflow checks out and packs the tag's commit, so the packages are v5.5.0's.


Generated by Claude Code

@polewskm
polewskm deployed to code-review November 21, 2026 17:43 — with GitHub Actions Active

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at aca7e43: 1 new finding on the changed lines.

Not on a changed line:

  • 🟡 F2 Nit: Comment above the baseline job says it opens a draft pull request, which it no longer does .github/workflows/publish.yml:168. The comment says the job "Opens the draft pull request that raises the package validation baseline". In fact raise-baseline.yml pushes baseline-<version> and opens an issue that links to the pull request, which a person then opens. Fix: Reword the comment: for a stable version, the job pushes baseline-<version> and opens an issue that links to the pull request that raises the baseline.

Comment thread CHANGELOG.md Resolved

@ncode-review-approver ncode-review-approver Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at aca7e43: no blocker or should-fix finding remains.

@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Superseded by the review at aca7e43.

@polewskm polewskm self-assigned this Nov 21, 2026
@polewskm
polewskm marked this pull request as ready for review November 21, 2026 17:45
@polewskm
polewskm deployed to code-review November 21, 2026 17:45 — with GitHub Actions Active

Copy link
Copy Markdown
Contributor Author

Autopilot: Both nits hold. Neither is fixed here, because a push would dismiss the approval and delay the v5.5.0 publish.


Generated by Claude Code

@polewskm

Copy link
Copy Markdown
Contributor Author

/review

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at aca7e43: 0 new findings on the changed lines.
1 more was already posted on this pull request.

Not on a changed line:

  • 🟠 F1 Should fix: Comments still say the baseline job opens a pull request; raise-baseline.yml now opens an issue .github/workflows/publish.yml:12. Two comments still describe the old behaviour: the file header at line 12 says raise-baseline.yml "opens the pull request that raises the package validation baseline", and the comment above the baseline job at line 168 says "Opens the draft pull request". raise-baseline.yml now pushes baseline-<version> and opens an issue whose link a person uses to open the pull request. Fix: Reword both comments to say the job pushes the baseline branch and opens an issue that links to the pull request. At line 168, also say why only contents: write and issues: write are granted: the caller has to grant what the called workflow declares.
  • 🟡 F3 Nit: Header comment says baseline opens a pull request, but raise-baseline.yml now opens an issue /home/runner/work/Buffers/Buffers/pr/.github/workflows/publish.yml:12. The file header describes raise-baseline.yml as the workflow that 'opens the pull request that raises the package validation baseline'. raise-baseline.yml (lines 1-5) pushes the branch and opens an issue whose link a person uses to open the pull request. This PR changes the baseline job's permissions to match that issue-based behavior but leaves this comment describing the old behavior. Fix: Reword the comment on lines 11-13 to say raise-baseline.yml pushes the baseline branch and opens an issue that links to the pull request.

@ncode-review-approver
ncode-review-approver Bot dismissed their stale review November 21, 2026 17:50

Dismissed: the review at aca7e43 doesn't approve.

@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Superseded by the review at de8b1ee.

Copy link
Copy Markdown
Contributor Author

Autopilot: Fixed in de8b1ee. Both comments in publish.yml say the baseline job pushes the branch and opens an issue whose link opens its pull request: the header's line about raise-baseline.yml and the comment above the baseline job. They match project-template v0.111.1's wording.

/review


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

/review


Generated by Claude Code

@ncode-review-approver ncode-review-approver Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at de8b1ee: no blocker or should-fix finding remains.

@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at aca7e43: 3 hunks in 2 files and changes taken back in 1 file, by correctness only. No further findings above nits.

Approval: Approved — no blocker or should-fix finding remains.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.02 on Amazon Bedrock, 7s, at de8b1ee. (how to interact)

📋 Outcomes

Merged at de8b1ee: 1 fixed, 0 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 conventions, rule-check 🟡 Nit ✅ fixed

@polewskm
polewskm enabled auto-merge November 21, 2026 17:51
@polewskm
polewskm merged commit a330eed into main Nov 21, 2026
11 checks passed
@polewskm
polewskm deleted the claude/charming-cray-q7vja4 branch November 21, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant