Conversation
`EpicGamesGameManager.install(game:qualityOfService:)` recursed until the stack died. The typed overload requires `forPlatform:` and offers no default, so the call inside the witness re-selected the witness itself (`EpicGamesGame` is a `Game`). `StorefrontGameManager.install` is therefore unusable for Epic today; the UI only works because `EpicGamesGameInstallationView` calls the five-argument overload directly. The witness now resolves a platform from `getSupportedPlatforms()`, preferring Windows. `LocalGameManager.move(game:to:)` built its operation with type `.uninstall` and never called `queueOperation`, so the returned operation was inert -- its `function` never ran and the move silently did nothing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pre-existing defects in
StorefrontGameManagerwitnesses, found while writing a new manager against them.EpicGamesGameManager.install(game:qualityOfService:)recursed until the stack died. The typed overload requiresforPlatform:and offers no default, so the call inside the witness re-selected the witness itself (EpicGamesGameis aGame).StorefrontGameManager.installis therefore unusable for Epic today — the UI only works becauseEpicGamesGameInstallationViewcalls the five-argument overload directly. The witness now resolves a platform fromgetSupportedPlatforms(), preferring Windows.LocalGameManager.move(game:to:)built its operation with type.uninstalland never calledqueueOperation, so the returned operation was inert: itsfunctionnever ran and moving a local game silently did nothing.No behaviour changes for anything that already worked.